Thanks Darius, that did the trick.

And to answer my previous question, it looks like, yes, the module jar should 
be included in the lib of the module omod, because it looks like in the maven 
build configuration, the api class files aren't added individually.

Mark


From: [email protected] [mailto:[email protected]] On Behalf Of Darius Jazayeri
Sent: Thursday, September 29, 2011 2:05 PM
To: [email protected]
Subject: Re: [OPENMRS-DEV] Mavenized module omod

Yes, you can specify exclusions in pom.xml. An example is for the 
org.apache.velocity include in trunk's root pom.xml.

-Darius
On Thu, Sep 29, 2011 at 11:00 AM, Mark Goodrich 
<[email protected]<mailto:[email protected]>> wrote:
I also noticed another difference in the lib file between a pre-mavenized and 
mavenized version of a module... the Patient Flags module uses Groovy, so in 
the pre-maven version of the module I added the groovy jar to the module lib 
folder.

One potential problem here was if another module also included the groovy jar 
you'd have two copies of the groovy jar installed.  I remember a discussion 
about this issue in the past, but I don't remember if there was any resolution.

This problem appears to be magnified in the mavenized version of the module. I 
am now including the Groovy module in patient flags by declaring it as a 
dependency within the pom, and now, along with the groovy jar, the antlr jar 
and all the asm jars show up in lib of the patient flags module, presumably 
because antlr and asm are listed as core dependencies in the groovy pom.  I 
assume we don't want to include these jars, since they are already included 
within the Openmrs core? And assumedly there is a way to configure the pom do 
this?

Mark


-----Original Message-----
From: [email protected]<mailto:[email protected]> 
[mailto:[email protected]<mailto:[email protected]>] On Behalf Of Mark Goodrich
Sent: Thursday, September 29, 2011 1:01 PM
To: 
[email protected]<mailto:[email protected]>
Subject: [OPENMRS-DEV] Mavenized module omod

It looks like when building a mavenized module omod using the poms generated by 
the module conversion script, the module jar is included in the lib folder of 
the packaged omod.  Should this be happening?

Also, just a quick point of reference... when adding one module as a dependency 
to another, make sure to set the <scope>provided</scope> parameter so that the 
jar of the dependency is not include in the lib folder of the generated omod... 
I had a hard-to-debug error yesterday due to the fact that I had two copies of 
the reporting jar in a single deployment.

https://wiki.openmrs.org/display/docs/Requiring+another+module+in+your+module

Mark

_________________________________________

To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to 
[email protected]<mailto:[email protected]> with "SIGNOFF 
openmrs-devel-l" in the  body (not the subject) of your e-mail.

[mailto:[email protected]<mailto:[email protected]>?body=SIGNOFF%20openmrs-devel-l]

_________________________________________

To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to 
[email protected]<mailto:[email protected]> with "SIGNOFF 
openmrs-devel-l" in the  body (not the subject) of your e-mail.

[mailto:[email protected]<mailto:[email protected]>?body=SIGNOFF%20openmrs-devel-l]

________________________________
Click here to 
unsubscribe<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l> 
from OpenMRS Developers' mailing list

_________________________________________

To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to 
[email protected] with "SIGNOFF openmrs-devel-l" in the  body (not 
the subject) of your e-mail.

[mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]

Reply via email to