I opened a ticket for you: https://tickets.openmrs.org/browse/TRUNK-2767
Ben On Mon, Oct 10, 2011 at 4:29 PM, Tammy Dugan <[email protected]> wrote: > Wyclif, > > Would you be able to open a ticket for this? What would be the time line > for getting this fixed and backported to 1.7.x so we don't have to use a > custom build? > > Thanks, > > Tammy > > > On 10/9/2011 9:30 AM, Wyclif Luyima wrote: > > @Darius, my suggestion was to convert the search string argument passed to > getConcepts to uppercase when building the hibernate criteria since > concept_word.word is always in uppercase and not the returned results. So > this should have no effect on any existing code besides getting rid of > ilike. > > Wyclif > > On Fri, Oct 7, 2011 at 4:29 PM, Tammy Dugan <[email protected]> wrote: > > I agree. You could break up the phrase into individual words and try to > match but I don't think concept word keeps track of word order so you could > potentially get multiple matches. > > Tammy > > > On 10/7/2011 4:13 PM, Darius Jazayeri wrote: > > I don't actually think that concept_word will work here. Since that > includes single words, but this is looking for a concept by exact name, and > that name may have multiple words... > > -Darius > > On Friday, October 7, 2011, Tammy Dugan wrote: > > I see. Thank you for the clarification. Wyclif, can you please open a > ticket for this since you were the one that suggested the solution? > > I still think someone should look into use of ilike in other methods to > evaluate the performance hit. > > Thanks, > > Tammy > > On 10/7/2011 3:34 PM, Burke Mamlin wrote: > > Get concepts should be using concept_word to search by name, in which case > – as Wyclif suggests – using like + name.toUpperCase() should suffice. > > -Burke > > On Fri, Oct 7, 2011 at 3:10 PM, Tammy Dugan <[email protected]> wrote: > > I understand that, Darius, but the sql that runs for ilike with MySQL is > unacceptably slow. Either there needs to be special processing for each > ilike in the case that MySQL is the database or otherwise another solution > needs to be used other than ilike. One example would be to have an > additional column in the concept name table with a a lowercase version of > the concept name and make sure the search phrase is changed to all lowercase > before it is passed to the sql. I know the exception is inconvenient but it > is necessary. Without the exception, the current version of logic is > unusably slow for us. > > Thanks, > > Tammy > > > > On 10/7/2011 2:52 PM, Darius Jazayeri wrote: > > Hi Tammy, > > We're not coding specifically against MySQL though. So we do in fact need > to use ilike. > > I agree that like + matchmode=exact should never be used. > > -Darius > > On Friday, October 7, 2011, Tammy Dugan wrote: > > I also want to point out that ilike is used in other places in the code. I > think all instances should be changed because every time it is used it > causes a performance hit in MySQL. Using like, exact match instead of "=" is > also a unnecessary performance hit wherever it is used. > > Thanks, > > Tammy > > On 10/7/2011 2:10 PM, Wyclif Luyima wrote: > > Concept words are converted to uppercase before they get saved, so a quick > possible solution would be to edit getConcepts to convert the search phrase > to uppercase before executing the query and then switch ilike to like. > > Wyclif > > On Fri, Oct 7, 2011 at 1:51 PM, Darius Jazayeri <[email protected]>wrote: > > I thought the whole point of ConceptWord was that we looked at that rather > than doing a query like the one Tammy mentions. (Tammy, which version of > getConcepts is that?) > > -Darius > > > On Friday, October 7, 2011, Tammy Dugan wrote: > > We have been testing CHICA with 1.7.x openmrs and have run into some > performance issues. It takes 4 or more times longer to create a form in > 1.7.x openmrs than 1.5 > > -- > Tammy Dugan > CHIRDL Technical Lead > Children's Health Services Research > IU School of Medicine > > Click here to unsubscribe from OpenMRS Developers' mailing list > > Click here to > unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from > OpenMRS Developers' mailing list > > > -- > Tammy Dugan > CHIRDL Technical Lead > Children's Health Services Research > IU School of Medicine > > Click here to > unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from > OpenMRS Developers' mailing list > > > Click here to > unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from > OpenMRS Developers' mailing list > > > -- > Tammy Dugan > CHIRDL Technical Lead > Children's Health Services Research > IU School of Medicine > > ------------------------------ > Click here to > unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from > OpenMRS Developers' mailing list > _________________________________________ To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to [email protected] with "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
