Dave- I don't have the names of those four failing unit tests in front of me, but I think I have them fixed... they were all failing with the same error, and the issue is making sure we include the right XML transform library via Maven... I'd say don't worry about it for now, but once you get back to a place with decent Internet access, take a look at the links to the ticket and the git commit below.
Thanks, Mark From: [email protected] [mailto:[email protected]] On Behalf Of Dave Thomas Sent: Thursday, November 17, 2011 1:01 AM To: [email protected] Subject: Re: [OPENMRS-DEV] HtmlFormEntry -- failing unit tests Mark, i'm traveling today, so its going to be hard for me to do the git/maven switch for htmlformentry quickly. Would you mind posting the names of the failing unit tests so I can see if any of these are mine? I have recently added a few new tests around the internal notion of schema and around the smart delete stuff. Also, I know that Lara submitted a patch recently, although I don't remember what it was. She couldn't apply the fix because the mavenization had started. Would you mind applying this fix for 1.7.4 if necessary? I think its a small fix. D On Nov 17, 2011 4:38 AM, "Mark Goodrich" <[email protected]<mailto:[email protected]>> wrote: So, I discovered today that in the mavened version of HtmlFormEntry not all the unit tests were being run because by default maven only executes test classes that end in "Test" while two of the classes in HFE ended in "Tests". I renamed these tests and discovered that we now have 5 failing unit tests. One test was a "known issue", but the other four introduced by the switch the maven. I managed to get these four tests to pass, but am unsure if what I did was correct... @Darius--can you take a look at: https://tickets.openmrs.org/browse/HTML-230 https://github.com/OpenMRS/openmrs-module-htmlformentry/commit/059d3b6614b298d76a3a2631ddfe74bdd09a191f Thanks, Mark _________________________________________ To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to [email protected]<mailto:[email protected]> with "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. [mailto:[email protected]<mailto:[email protected]>?body=SIGNOFF%20openmrs-devel-l] ________________________________ Click here to unsubscribe<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l> from OpenMRS Developers' mailing list _________________________________________ To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to [email protected] with "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
