Hi all,

A couple of things here:

* I made this fix a few weeks ago (when you first reported this issue), but this has not yet been uploaded to the module repository since I do not fully know what else has changed in the module since the 1.7.0 version and do not want to release unstable code inadvertently. You should be able to just build this from source and test it out as is, since it sounds like you already have the module checked out. This will appear to be version 1.7.2 for you.

* A ticket was already created for this issue (by me, when you reported it) here: https://tickets.openmrs.org/browse/SLE-14

Can you please try this out and let me know if you still have problems?

Thanks,
Mike



On 11/18/2011 07:34 AM, Ben Wolfe wrote:
http://tickets.openmrs.org --> click Create Issue on the right

On Fri, Nov 18, 2011 at 3:18 PM, Erick Mugoma <[email protected] <mailto:[email protected]>> wrote:

    Done it Ben.

    So how do i create a JIRA Ticket to fix this problem.
    I'll be glad to know how this is done

    Thanks

    Erick




    On Fri, Nov 18, 2011 at 2:35 PM, Ben Wolfe <[email protected]
    <mailto:[email protected]>> wrote:

        Control-shift-r in eclipse for the file: orderEntry.jsp .  Do
        a control-l to jump to line 555.  Remove anything in the
        <c:choose tag that isn't a tag itself.  It should just be html
        comments that you remove: "<!-- ........... -->"

        Then rebuild the module: ant package-module

        Then redeploy the omod in the dist folder.

        Ben


        On Fri, Nov 18, 2011 at 2:18 PM, Erick Mugoma
        <[email protected] <mailto:[email protected]>> wrote:

            I've the module check out.
            Can maybe guide me on where this error is coming from then
            I try to fix it myself.

            This error is being thrown when I click the orders link.
            Am ready now can we start?
            Erick


            On Fri, Nov 18, 2011 at 1:39 PM, Ben Wolfe
            <[email protected] <mailto:[email protected]>> wrote:

                Your options are to either keep trying lower versions
                of tomcat, check out the source and fix it, or open a
                new ticket in JIRA for this module and have them fix it.

                (or even a combination of 2 and 3 to make the module
                author really happy)

                Ben


                On Fri, Nov 18, 2011 at 1:14 PM, Erick Mugoma
                <[email protected]
                <mailto:[email protected]>> wrote:

                    Hi Ben
                    6.0.18 and 6.0.20 still not working.
                    Am in the wilderness hope I get out soon.

                    Thanks


                    On Fri, Nov 18, 2011 at 10:35 AM, Ben Wolfe
                    <[email protected] <mailto:[email protected]>> wrote:

                        I think 6.0.18 or 6.0.20 is the sweet spot,
                        but I might be remembering wrong.  (Its very
                        annoying that tomcat makes high implication
                        changes like this in maintenance releases)

                        Ben


                        On Fri, Nov 18, 2011 at 10:07 AM, Erick Mugoma
                        <[email protected]
                        <mailto:[email protected]>> wrote:

                            Hi Ben,
                            What tomcat version would suggest that I
                            go for because I need to sort out this
                            issue so that we can have a smooth
                            transition with all the modules that we
                            are currently running.

                            I'll be glad to have this work for us.

                            Thanksks

                            On Fri, Nov 18, 2011 at 9:24 AM, Ben Wolfe
                            <[email protected] <mailto:[email protected]>>
                            wrote:

                                That should be a quick fix inside the
                                simple lab module.  Looks like there
                                is a comment inside of <c:choose tag
                                that tomcat isn't liking (I'm guessing
                                a previous version of tomcat allowed
                                it, thats why the module is released
                                with this)

                                Ben


                                On Fri, Nov 18, 2011 at 9:09 AM, Erick
                                Mugoma <[email protected]
                                <mailto:[email protected]>> wrote:

                                    Hi Ben, Dave and Mike
                                    Am running the simple lab module
                                    (1.7.0) on openmrs 1.6.2 and
                                    tomcat 5.5. This works very fine.

                                    Unfortunately the lab module
                                    (1.7.0) is having errors on
                                    openmrs 1.8.2 and tomcat 6.0.29.
                                    see the error below. Is the lab
                                    module not compatible with 1.8.2
                                    or this is problem with tomcat
                                    6.0.29. Wot options do I have
                                    because we are not able to upgrade
                                    to 1.8.2 if the lab module is not
                                    able able run.


                                        An Internal Error has Occurred

                                    *org.apache.jasper.JasperException*

                                    <h3>Validation error messages from TagLibraryValidator for c_rt in 
/WEB-INF/view/module/simplelabentry/orderEntry.jsp</h3><p>555: Illegal text inside "c:choose" tag: "<!-- 
If...".</p><p>571: Illegal text inside "c:choose" tag: "<!-- Ot...".</p>



                                    Consult the help document
                                    <http://127.0.0.1:8080/openmrs/help.htm>.

                                    Contact your friendly neighborhood
                                    administrator if it cannot be
                                    resolved.

                                    Hide stack trace
                                    
<http://127.0.0.1:8080/openmrs/module/simplelabentry/orderEntry.htm#>



                                    ** Root cause is:


                                          Validation error messages
                                          from TagLibraryValidator for
                                          c_rt in
                                          
/WEB-INF/view/module/simplelabentry/orderEntry.jsp

                                    555: Illegal text inside
                                    "c:choose" tag: "

                                    The following data will be
                                    submitted with the report to
                                    enable the team to resolve the
                                    problem.

                                        * The error message and stack
                                          trace
                                        * OpenMRS version
                                        * Application server name and
                                          version
                                        * Username of the user
                                          currently logged in
                                        * The implementation id of
                                          this installation (if defined)
                                        * Names and versions of all
                                          installed modules

                                    571: Illegal text inside
                                    "c:choose" tag: "


                                
------------------------------------------------------------------------
                                Click here to unsubscribe
                                
<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l>
from OpenMRS Developers' mailing list


                        
------------------------------------------------------------------------
                        Click here to unsubscribe
                        
<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l>
                        from OpenMRS Developers' mailing list


                    
------------------------------------------------------------------------
                    Click here to unsubscribe
                    
<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l>
                    from OpenMRS Developers' mailing list


                
------------------------------------------------------------------------
                Click here to unsubscribe
                
<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l>
                from OpenMRS Developers' mailing list


            
------------------------------------------------------------------------
            Click here to unsubscribe
            <mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l>
            from OpenMRS Developers' mailing list


        ------------------------------------------------------------------------
        Click here to unsubscribe
        <mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l>
        from OpenMRS Developers' mailing list


    ------------------------------------------------------------------------
    Click here to unsubscribe
    <mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l> from
    OpenMRS Developers' mailing list


------------------------------------------------------------------------
Click here to unsubscribe <mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l> from OpenMRS Developers' mailing list

_________________________________________

To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to 
[email protected] with "SIGNOFF openmrs-devel-l" in the  body (not 
the subject) of your e-mail.

[mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]

Reply via email to