Generally speaking, if the unit test has invalid data, you should fix that data, not change the code to handle invalid data.
-Darius On Tue, Nov 29, 2011 at 9:02 AM, Jeremy Keiper <[email protected]> wrote: > I realize the API should be enforcing a policy where every user has a > person and every person has at least one person name, but when that is not > in place (e.g. when a unit test's data set has a user tied to a person but > no person name) and you are searching for users based on roles (e.g. > Context.getUserService().getUsers(null, roles, null, null, null)), the > roles are overlooked because of the "inner join user.person.names as name " > in the HQL. > > Is this an acceptable silent failure, or should I file a ticket to fix > that somehow, like with a left join instead? > > Jeremy Keiper > OpenMRS Core Developer > AMPATH / IU-Kenya Support > ------------------------------ > Click here to > unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from > OpenMRS Developers' mailing list _________________________________________ To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to [email protected] with "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
