Just a minor point here... there were some changes made to the way the 
isObsGrouping and hasGroupMembers  works in 1.9.0 but I'm questioning now if 
we've made the right decision.

To do a quick summary:

In 1.9.0, the default parameter-less obs.hasGroupMembers()  and 
obs.isObsGrouping() methods return true if the obs in question havs 1 or more 
*non-voided* member obs.

This seems like the right behavior for hasGroupMembers (and there also now a 
hasGroupMembers(Boolean includeVoided) if you want to override this behavior) 
but I would think perhaps that obs.isObsGrouping() should return true if the 
obs in question has 1 or more members obs *of any type*, voided *or* non-voided.

The logic is like this... if you have an obs that has two child obs that are 
both voided, even though I would say it "has no group members" I would still 
consider it "an obs grouping".

Thoughts?

Mark

_________________________________________

To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to 
[email protected] with "SIGNOFF openmrs-devel-l" in the  body (not 
the subject) of your e-mail.

[mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]

Reply via email to