Can you remind those module developers how to do this? (Is there a wiki
page?)

-Darius

On Wed, Nov 30, 2011 at 10:50 AM, Mark Goodrich <[email protected]> wrote:

> Yes, I’ve discovered that running the HFE unit tests against 1.9.0-alpha
> (and other versions of Openmrs) is a good way to discover potential issues
> in core.  I’d recommend any module owners with mavenized modules try it out.
> ****
>
> ** **
>
> For what it’s worth, I think I have all HFE unit test errors against
> 1.9.0-alpha fixed or potentially fixed pending an active ticket.****
>
> ** **
>
> Mark****
>
> ** **
>
> *From:* [email protected] [mailto:[email protected]] *On Behalf Of *Darius
> Jazayeri
> *Sent:* Wednesday, November 30, 2011 1:25 PM
> *To:* [email protected]
> *Subject:* Re: [OPENMRS-DEV] 1.9.0-alpha setProvider(Person) method
> triggers hibernate flush****
>
> ** **
>
> Hi Mark,****
>
> ** **
>
> Rafal is working on this now, so add yourself as a watcher on TRUNK-2015
> and re-test this against trunk when he's committed something.****
>
> ** **
>
> We've been having trouble tracking down all the possible edge cases of
> this, so running the HFE unit tests would be really nice.****
>
> ** **
>
> -Darius****
>
> On Wed, Nov 30, 2011 at 9:41 AM, Mark Goodrich <[email protected]> wrote:*
> ***
>
> I just ran into another flushing-related issue while running the Html Form
> Entry unit tests against the 1.9.0-alpha…****
>
>  ****
>
> When changing the provider model in 1.9.0, the legacy setProvider(Person)
> method was depreciated but was also modified to provide backwards
> compatibility with the existing provider module.  To do this, service
> methods which execute db queries are now called from within the setProvider
> method.  These queries end up triggering a hibernate flush, which, in turn,
> is causing an a “not-null property references a null or transient value” on
> a dateCreated in certain cases within HFE.****
>
>  ****
>
> This is another reason for moving dateCreated into the
> AuditableInterceptor (TRUNK-2015) sooner rather than later.  Looks like
> this is scheduled to be fixed for 1.9 beta so I’m going to ignore these
> failing unit tests against 1.9.0-alpha and I will test again after the beta
>  comes out.****
>
>  ****
>
> I will add, however, that having  a setter method trigger a flush might
> cause other unexpected issues.****
>
>  ****
>
> Mark****
>
>  ****
>
>  ****
> ------------------------------
>
> Click here to 
> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from 
> OpenMRS Developers' mailing list
> ****
>
> ** **
> ------------------------------
>
> Click here to 
> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from 
> OpenMRS Developers' mailing list
> ****
> ------------------------------
> Click here to 
> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from 
> OpenMRS Developers' mailing list
>

_________________________________________

To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to 
[email protected] with "SIGNOFF openmrs-devel-l" in the  body (not 
the subject) of your e-mail.

[mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]

Reply via email to