Thanks Ben... I waiting for this before mavenizing Address Hierarchy, and now I can follow your lead and try to clean the structure of patient flags and mdrtb as well...
Mark ________________________________________ From: [email protected] [[email protected]] On Behalf Of Ben Wolfe [[email protected]] Sent: Friday, December 02, 2011 6:19 AM To: [email protected] Subject: Re: [OPENMRS-DEV] Incorrect mvn module setup I updated the mavenize scripts on this wiki page today: https://wiki.openmrs.org/display/docs/Converting+old+code+to+Maven With this change the mavenmodule artifactIds are now moduleId/moduleId-api/moduleId-omod. The omod packaging is fixed so that it imports cleanly into eclipse as well. I changed all of the projects in my workspace to the new layout as well. So if you want an example of how you can change yours see some of my commits from today<https://source.openmrs.org/user/bwolfe?max=30&maxDate=1322823389594&name=bwolfe&prevPageAnchor=changeset%3A24701&view=fe>. rev:24698<https://source.openmrs.org/changelog/Modules?cs=24698> is a good example of both changes. and rev:24695<https://source.openmrs.org/changelog/Modules?cs=24695> is just the naming change. I have a suspicion that the unit tests can't be in the api because they depend on the omod being packaged in order to test. I might be wrong on that, so someone should test it out. Ben On Tue, Nov 8, 2011 at 12:46 AM, Darius Jazayeri <[email protected]<mailto:djazayeri%[email protected]>> wrote: I agree 110% with Win (and this was the consensus on that other thread). By default modules should have both moduleApplicationContext.xml in /api, and webModuleApplicationContext.xml in /omod. Is there a reason we don't do this already? -Darius On Mon, Nov 7, 2011 at 12:54 PM, Nyoman Ribeka <[email protected]<mailto:[email protected]>> wrote: Rafal, This is the same concern I raise in the mailing list in another thread. I think we really need a design discussion on this one :) The API Spring configuration should go to the API part of the module and the web spring configuration should stay in the omod part of the module. Check the "FW: HTML form entry changes" email thread. On Mon, Nov 7, 2011 at 3:06 PM, Rafal Korytkowski <[email protected]<mailto:[email protected]>> wrote: > Hey, > > Mavenized modules consist of the api and omod subprojects. This setup > is not quite right since one cannot write context sensitive tests in > the api subproject. The reason is that resources for creating the > Spring Context are in the omod subproject, thus context sensitive > tests must be placed there. I believe we should reorganize things and > make it possible to write tests in the api subproject. Does anyone > know reasoning behind the current "strange" structure? Would there be > any problems if we changed that? > > -Rafal > > _________________________________________ > > To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to > [email protected]<mailto:[email protected]> with "SIGNOFF > openmrs-devel-l" in the body (not the subject) of your e-mail. > > [mailto:[email protected]<mailto:[email protected]>?body=SIGNOFF%20openmrs-devel-l] > -- Thanks, Nyoman Ribeka _________________________________________ To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to [email protected]<mailto:[email protected]> with "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. [mailto:[email protected]<mailto:[email protected]>?body=SIGNOFF%20openmrs-devel-l] ________________________________ Click here to unsubscribe<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l> from OpenMRS Developers' mailing list ________________________________ Click here to unsubscribe<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l> from OpenMRS Developers' mailing list _________________________________________ To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to [email protected] with "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
