Not filtering the webapp portion seems right to me. I can't think of a reason to filter it but doing the filtering can lead to a hard "bug" for a new user to figure out as you pointed out.
Can you open a ticket for the mavenize scripts to be fixed? The maven module archetype will need to be changed as well, theres a separate jira project for that. Patches are welcome too. :-) Ben On Mon, Dec 12, 2011 at 4:09 PM, Rowan Seymour <[email protected]>wrote: > Both the module-wizard and the mavenization scripts create projects with > filtering applied to all resources in src/main/webapp. This means that any > occurence of something like ${name} or ${id} gets replaced by a value from > the POM. Should we change this so that only files in src/main/resources are > filtered? > > It's quite common for something like ${name} to occur in a JSP or TAG file > and I don't think anyone is expecting that to become a POM property... > > This is what we currently have in the OMOD POM... > > <resource> > <directory>src/main/resources</directory> > *<filtering>true</filtering>* > </resource> > <resource> > <directory>src/main/webapp</directory> > *<filtering>true</filtering>* > <excludes> > <exclude>resources</exclude> > </excludes> > <targetPath>web/module</targetPath> > </resource> > > -Rowan > ------------------------------ > Click here to > unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from > OpenMRS Developers' mailing list _________________________________________ To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to [email protected] with "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
