It was decided during the hackathon in Rwanda before the Implementers' Conference that we would go this route. It allows a FormResource to be completely flexible, like a GlobalProperty, but does not require types (like a VisitAttribute does).
As for the implementation of FormResource, I followed the same methodology (almost verbatim) as GlobalProperty. If we have a concern about the permanence of assigning a Custom Datatype to a FormResource, we will have the same problem with GlobalProperty objects. I suggest we bring this up on a design call if it is necessary. Jeremy Keiper OpenMRS Core Developer AMPATH / IU-Kenya Support On Thu, Jan 19, 2012 at 1:56 PM, Burke Mamlin <[email protected]>wrote: > Thanks for doing this Jeremy. > > So there's a single FormResource class that works with values as Objects? > I thought that there would be a FormResource interface with > implementations that would have datatype-specific methods – e.g., > > interface FormResource<T> { > …. > public T getValue(); > void setValue(T value); > } > > Did we already discuss this & decide against it for some reason? I'm not > recalling. If we *are* going with a single implementation that takes & > returns Objects that must be casted, then shouldn't the datatype class name > be in the constructor so it can't be changed after a value is set? > > -Burke > > On Thu, Jan 19, 2012 at 10:33 AM, Jeremy Keiper <[email protected]>wrote: > >> I updated a wiki page here: >> https://wiki.openmrs.org/display/docs/Forms#Forms-FormResources >> >> I have not finished development on it, but when I do there will be >> screenshots of the Form Resource management pages. Please review the >> information there and let me know what you feel is missing. Thanks! >> >> Jeremy Keiper >> OpenMRS Core Developer >> AMPATH / IU-Kenya Support >> ------------------------------ >> Click here to >> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >> OpenMRS Developers' mailing list > > > ------------------------------ > Click here to > unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from > OpenMRS Developers' mailing list _________________________________________ To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to [email protected] with "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
