Oh i see!!! You are are actually not missing anything and thanks for the correction!!!
The patientflags module needs its config require_module changed from "org.openmrs.logic" to "org.openmrs.module.logic" @Mark, could you change that and send me the updated version of the patientflags module to bundle with 1.9 RC? The logic module has been using package name "org.openmrs.logic" instead of "org.openmrs.module.logic" and i think that was possibly because it did not start as a module and we forgot to change it. On Sun, Mar 4, 2012 at 5:47 PM, Mark Goodrich <[email protected]> wrote: > Daniel-- > > Great... Yes, making the change in LOGIC-96 and then changing > <MODULE_PACKAGE> makes sense because it makes logic in line with the rest > of the modules. > > I'm probably missing something obvious, but the one thing that confuses me > is why in patient flags config require_module is the logic module specified > as org.openmrs.logic instead of org.openmrs.module.logic? > > Mark > ________________________________________ > From: [email protected] [[email protected]] On Behalf Of Daniel Kayiwa [ > [email protected]] > Sent: Sunday, March 04, 2012 2:54 AM > To: [email protected] > Subject: Re: [OPENMRS-DEV] patientflags module does not start on trunk and > 1.9 > > Hi Mark, > > The commit you made for LOGIC-96 was very correct and that is how the rest > of the modules do it. > The patient flags module is also very correct hence needs no further > changes. > The only needed change is for the pom file under the logic-omod project > where "<MODULE_PACKAGE>${project.parent.groupId}</MODULE_PACKAGE>" needs to > become > "<MODULE_PACKAGE>${project.parent.groupId}.${project.parent.artifactId}</MODULE_PACKAGE>" > > > On Sun, Mar 4, 2012 at 6:29 AM, Mark Goodrich <[email protected]<mailto: > [email protected]>> wrote: > I made this change a while back : LOGIC-96. I forget the exact reason I > changed it, but it seemed like it was an error. Looks like I should have > changed the <MODULE_PACKAGE> as well... ? Or was I mistaken in changing the > groupId in the first place? And is there anything else I need to change in > the patient flags module, or is > <require_module>org.openmrs.logic</require_module> correct? I'm still a > little confused. > > > ________________________________________ > From: [email protected]<mailto:[email protected]> [[email protected]<mailto: > [email protected]>] On Behalf Of Daniel Kayiwa [[email protected]<mailto: > [email protected]>] > Sent: Saturday, March 03, 2012 3:20 PM > To: [email protected]<mailto: > [email protected]> > Subject: Re: [OPENMRS-DEV] patientflags module does not start on trunk and > 1.9 > > The pom file in the logic module had this: > > > <properties> > > <MODULE_PACKAGE>${project.parent.groupId}</MODULE_PACKAGE> > > </properties> > > instead of: > > > <properties> > > > <MODULE_PACKAGE>${project.parent.groupId}.${project.parent.artifactId}</MODULE_PACKAGE> > > </properties> > > > On Sat, Mar 3, 2012 at 11:03 PM, Mark Goodrich <[email protected]<mailto: > [email protected]><mailto:[email protected]<mailto:[email protected]>>> > wrote: > Ah.. So did the logic module package change at some point? > ________________________________ > From: Daniel Kayiwa > Sent: 3/3/2012 2:38 PM > To: [email protected]<mailto: > [email protected]><mailto: > [email protected]<mailto: > [email protected]>> > Subject: Re: [OPENMRS-DEV] patientflags module does not start on trunk and > 1.9 > > > > That is all in the log file. > > Looking at this section of the error message: > org.openmrs.module.ModuleException: Not all required modules are started: > org.openmrs.logic. Module: Patient Flags Module > > After running the application in debug mode, i discovered that that the > version (0.5.1) of the logic module that am running has a config.xml file > with package "org.openmrs.module" instead of "org.openmrs.logic" > > That is the cause of the problem. > > > On Fri, Mar 2, 2012 at 6:40 PM, Ben Wolfe <[email protected]<mailto: > [email protected]><mailto:[email protected]<mailto:[email protected]>>> wrote: > There has to be something else in your logs before this that caused logic > to not even start. A spring error perhaps? Or a hibernate mapping error > printed? > > Ben > > On Fri, Mar 2, 2012 at 10:23 AM, Daniel Kayiwa <[email protected] > <mailto:[email protected]><mailto:[email protected]<mailto: > [email protected]>>> wrote: > > Hi all, > > Does the patient flags module start on your trunk/1.9 ? > I got it from the module repository: patientflags-1.3.3-r25745.omod > I get this stack trace when i try start it: > > WARN - ModuleFactory.startModuleInternal(603) |2012-03-02 17:31:32,391| > Error while trying to start module: patientflags > org.openmrs.module.ModuleException: Not all required modules are started: > org.openmrs.logic. Module: Patient Flags Module > at > org.openmrs.module.ModuleFactory.startModuleInternal(ModuleFactory.java:491) > at org.openmrs.api.context.Daemon$1.run(Daemon.java:57) > INFO - LoggingAdvice.invoke(117) |2012-03-02 17:31:32,459| In method > AlertService.saveAlert. Arguments: Alert=Alert: #null, > INFO - LoggingAdvice.invoke(142) |2012-03-02 17:31:32,464| Exiting method > saveAlert > WARN - ModuleFactory.stopModule(829) |2012-03-02 17:31:32,470| Unable to > call module's Activator.willStop() method > org.openmrs.module.ModuleException: The classloader is null Module: > patientflags > at org.openmrs.module.Module.getModuleActivator(Module.java:181) > at org.openmrs.module.ModuleFactory.stopModule(ModuleFactory.java:825) > at > org.openmrs.module.ModuleFactory.startModuleInternal(ModuleFactory.java:614) > at org.openmrs.api.context.Daemon$1.run(Daemon.java:57) > INFO - LoggingAdvice.invoke(117) |2012-03-02 17:31:32,486| In method > AdministrationService.saveGlobalProperty. Arguments: > GlobalProperty=property: patientflags.started value: false, > INFO - LoggingAdvice.invoke(142) |2012-03-02 17:31:32,491| Exiting method > saveGlobalProperty > WARN - ModuleFactory.stopModule(926) |2012-03-02 17:31:32,496| Unable to > call module's Activator.shutdown() method > org.openmrs.module.ModuleException: The classloader is null Module: > patientflags > at org.openmrs.module.Module.getModuleActivator(Module.java:181) > at org.openmrs.module.ModuleFactory.stopModule(ModuleFactory.java:920) > at > org.openmrs.module.ModuleFactory.startModuleInternal(ModuleFactory.java:614) > at org.openmrs.api.context.Daemon$1.run(Daemon.java:57) > WARN - ModuleFactory.removeClassLoader(966) |2012-03-02 17:31:32,497| > Module: patientflags does not exist > > > -- > The greatest want of the world is the want of men—men who will not be > bought or sold, men who in their inmost souls are true and honest, men who > do not fear to call sin by its right name, men whose conscience is as true > to duty as the needle to the pole, men who will stand for the right though > the heavens fall. > ________________________________ > Click here to unsubscribe<mailto:[email protected]<mailto: > [email protected]>?body=SIGNOFF%20openmrs-devel-l> from OpenMRS > Developers' mailing list > > ________________________________ > Click here to unsubscribe<mailto:[email protected]<mailto: > [email protected]>?body=SIGNOFF%20openmrs-devel-l> from OpenMRS > Developers' mailing list > > > > -- > The greatest want of the world is the want of men—men who will not be > bought or sold, men who in their inmost souls are true and honest, men who > do not fear to call sin by its right name, men whose conscience is as true > to duty as the needle to the pole, men who will stand for the right though > the heavens fall. > ________________________________ > Click here to unsubscribe<mailto:[email protected]<mailto: > [email protected]>?body=SIGNOFF%20openmrs-devel-l> from OpenMRS > Developers' mailing list > ________________________________ > Click here to unsubscribe<mailto:[email protected]<mailto: > [email protected]>?body=SIGNOFF%20openmrs-devel-l> from OpenMRS > Developers' mailing list > > > > -- > The greatest want of the world is the want of men—men who will not be > bought or sold, men who in their inmost souls are true and honest, men who > do not fear to call sin by its right name, men whose conscience is as true > to duty as the needle to the pole, men who will stand for the right though > the heavens fall. > ________________________________ > Click here to unsubscribe<mailto:[email protected]<mailto: > [email protected]>?body=SIGNOFF%20openmrs-devel-l> from OpenMRS > Developers' mailing list > _________________________________________ > > To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to > [email protected]<mailto:[email protected]> with > "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. > > [mailto:[email protected]<mailto:[email protected] > >?body=SIGNOFF%20openmrs-devel-l] > > > > -- > The greatest want of the world is the want of men—men who will not be > bought or sold, men who in their inmost souls are true and honest, men who > do not fear to call sin by its right name, men whose conscience is as true > to duty as the needle to the pole, men who will stand for the right though > the heavens fall. > ________________________________ > Click here to > unsubscribe<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l> > from OpenMRS Developers' mailing list > > _________________________________________ > > To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to > [email protected] with "SIGNOFF openmrs-devel-l" in the body > (not the subject) of your e-mail. > > [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l] > -- The greatest want of the world is the want of men—men who will not be bought or sold, men who in their inmost souls are true and honest, men who do not fear to call sin by its right name, men whose conscience is as true to duty as the needle to the pole, men who will stand for the right though the heavens fall. _________________________________________ To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to [email protected] with "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
