Ah, ok, I remember that now. Didn't notice that all the other ones changed too. I guess we had left that out initially? You were 100% correct to put that in there for 1.8 then! Most users only care about the schema changes, I think thats why Burke leaves that out.
As for the colors, you might need to do something outside of the workbench. Photoshop? Some other svg editors? A generic image editor would let you change anything you want, but it would be a little bit more work. (but I think its worth it!) Ben On Mon, Mar 26, 2012 at 11:32 AM, Nimantha Baranasuriya <[email protected] > wrote: > Hi Ben, > > In 1.8, the location/person_address.neighborhood_cell were renamed to > address3. So were the other related columns mentioned below. > > - Rename neighborhood_cell column to address3 and increase the size to > 255 characters > - Rename township_division column to address4 and increase the size to > 255 characters > - Rename subregion column to address5 and increase the size to 255 > characters > - Rename region column to address6 and increase the size to 255 > characters > - Rename neighborhood_cell column to address3 and increase the size to > 255 characters > - Rename township_division column to address4 and increase the size to > 255 characters > - Rename subregion column to address5 and increase the size to 255 > characters > - Rename region column to address6 and increase the size to 255 > characters > > > The first 4 columns were in the person table and the last 4 were in the > person_address table. > > As for the foreign key relationship between person and user in 1.7, I > added it because that was mentioned in the liquibase-update-to-latest.xml. > > <changeSet id="200912031846-3" author="djazayeri"> > <preConditions onFail="MARK_RAN"> > <not> > <foreignKeyConstraintExists foreignKeyName="person_id_for_user"/> > </not> > </preConditions> > <comment>Restoring foreign key constraint on users.person_id</comment> > <addForeignKeyConstraint constraintName="person_id_for_user" > baseTableName="users" baseColumnNames="person_id" > referencedTableName="person" referencedColumnNames="person_id"/> > <addAutoIncrement tableName="users" columnName="user_id" > columnDataType="int"/> > </changeSet> > > However, I noticed now that Burke's script does not provide that > particular change in the output. If you look at the 1.7 release notes page, > you will see that this change is not listed. So I removed the foreign key > relationship from the 1.7 model and updated the files again. Should that > line be added or not Ben? > > As for changing the line color, I am afraid I don't think its doable. I > did some searching on Google but couldn't find anything helpful. I tried > changing the line properties in Workbench, but it only allows me to hide or > show the line. Anyway, I will try some more to find any resources which > might help me make that change. > > Regards, > Nimantha > > > On Mon, Mar 26, 2012 at 10:37 PM, Ben Wolfe <[email protected]> wrote: > >> These look great! >> >> I didn't go through the entire datamodel, but clicking back and forth >> between 1.7 and 1.8 I have a few questions: >> What happened to location/person_address.neighborhood_cell? Surely we >> didn't delete those columns... >> Why is there a new line between person and user? >> >> Can you make the connecting lines a light gray so that they don't >> dominate the image? >> >> Ben >> >> >> On Sun, Mar 25, 2012 at 11:24 PM, Nimantha Baranasuriya < >> [email protected]> wrote: >> >>> Hi Ben and Michael, >>> >>> I completed the new data models for OpenMRS 1.7.0 and 1.8.0. They are >>> now available from our wiki in the forms of MySQL workbench format, SVG >>> format and PNG format. I made them available from the Data Model ( >>> https://wiki.openmrs.org/display/docs/Data+Model ) page so that users >>> have a single point of access for all versions of the data model (i.e. 1.6, >>> 1.7 and 1.8). Future models can also be appended to the same page. >>> >>> Furthermore I also updated the release notes pages of OpenMRS 1.7.0 and >>> 1.8.0 ( https://wiki.openmrs.org/display/RES/Release+Notes+1.7.0 , >>> https://wiki.openmrs.org/display/RES/Release+Notes+1.8.0 ) with the >>> data model changes that were found out by Burke's script. I also added a >>> link to both pages to the Data Model page so that people who want to see >>> the new data model can visit the Data Model page and if needed compare the >>> diagrams to older versions. >>> >>> Ben, if you have some free time please review the pages and the new >>> models and let me know if they require any changes. >>> >>> Regards, >>> Nimantha >>> >>> >>> On Sun, Mar 25, 2012 at 1:25 AM, Ben Wolfe <[email protected]> wrote: >>> >>>> The image might as well be on both pages. Either upload them twice or >>>> link from one page to the other's attachment. (I would prefer they all be >>>> in one place, so if you're only uploading once, do it on the Data Model >>>> page) >>>> >>>> Active lists are linked to Person objects, so you can enlarge that and >>>> put it in there. >>>> >>>> Thanks Nimantha! >>>> >>>> Ben >>>> >>>> >>>> On Sat, Mar 24, 2012 at 6:26 AM, Nimantha Baranasuriya < >>>> [email protected]> wrote: >>>> >>>>> One more question to add to the list. >>>>> >>>>> While creating the new data model for 1.7, four new tables were added. >>>>> Namely; >>>>> 1. active_list_type >>>>> 2. active_list >>>>> 3. active_list_allergy >>>>> 4. active_list_problem >>>>> >>>>> The existing table groupings are as follows: >>>>> 1. User >>>>> 2. Person >>>>> 3. Patient >>>>> 4. Groups/Workflows >>>>> 5. Encounter >>>>> 6. Observation >>>>> 7. Concept >>>>> 8. Business >>>>> 9. Order >>>>> 10. Form >>>>> >>>>> The question is, to which grouping does the above mentioned 4 new >>>>> tables belong? If they are better off in a new grouping, what should the >>>>> grouping be called? >>>>> >>>>> Regards, >>>>> Nimantha >>>>> >>>>> On Sat, Mar 24, 2012 at 12:53 PM, Nimantha Baranasuriya < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi Michael and Ben, >>>>>> >>>>>> Michael, I got the file you sent. Thanks! However I tried out the >>>>>> script in the wiki page Ben has sent and it seems it is much easier to >>>>>> modify the 1.6 data model than rendering a new model from scratch. There >>>>>> were 40 changes from 1.6 to 1.7 which I have almost completed adding to >>>>>> the >>>>>> 1.6 model. I will complete it and send it back to you so that you can >>>>>> compare it with the model you created from Toad. That will help to verify >>>>>> the diagram. >>>>>> >>>>>> Ben, thanks for the pointing me towards the wiki page having Burke's >>>>>> script. It was very useful as I mentioned earlier. I will also modify the >>>>>> release notes pages of 1.7 and 1.8 with the output from the script. Also, >>>>>> in which wiki page should the new data model files be attached? Should I >>>>>> modify the page https://wiki.openmrs.org/display/docs/Data+Model or >>>>>> else create two new pages for 1.7 and 1.8 and attach the new files there? >>>>>> >>>>>> Regards, >>>>>> Nimantha >>>>>> >>>>>> >>>>>> On Sat, Mar 24, 2012 at 12:38 AM, Michael Aro <[email protected] >>>>>> > wrote: >>>>>> >>>>>>> I'll investigate and work with Nimantha. >>>>>>> >>>>>>> M. >>>>>>> >>>>>>> >>>>>>> On Fri, Mar 23, 2012 at 6:21 PM, Ben Wolfe <[email protected]> wrote: >>>>>>> >>>>>>>> You will want to go off of the liquibase changesets. See this wiki >>>>>>>> page: >>>>>>>> >>>>>>>> https://wiki.openmrs.org/display/docs/Finding+Database+Changes+Between+Releases >>>>>>>> >>>>>>>> That mysqldiff.sql file is the old pre-liquibase upgrades. It >>>>>>>> takes users UP TO 1.4.2 and then liquibase takes users up to the latest >>>>>>>> release. (Hopefully there aren't many users still pre 1.4.2!!) Long >>>>>>>> story >>>>>>>> short: that file won't help you here. >>>>>>>> >>>>>>>> We should update those old release notes page with the output from >>>>>>>> Burke's script... >>>>>>>> >>>>>>>> >>>>>>>> Ben >>>>>>>> >>>>>>>> On Fri, Mar 23, 2012 at 10:50 AM, Nimantha Baranasuriya < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> I will start from the mwb file. I opened it with MySQL Workbench >>>>>>>>> and I noticed that tables can be modified and the SVG can be >>>>>>>>> generated from >>>>>>>>> it without any issues. >>>>>>>>> >>>>>>>>> Ben, can you please point me towards where the sqldifs are stored? >>>>>>>>> I went through the wiki pages having the release notes for 1.7.0 and >>>>>>>>> 1.8.0 >>>>>>>>> and couldn't find them on those pages. I also checked inside the >>>>>>>>> openmrs.war file in the official release in sourceforge but couldn't >>>>>>>>> find >>>>>>>>> it there as well. >>>>>>>>> >>>>>>>>> However I found a sqldiff file in the 1.7.0 branch ( >>>>>>>>> http://svn.openmrs.org/openmrs/branches/1.7.x/metadata/model/archive/update-to-1.4.2.01-db.mysqldiff.sql). >>>>>>>>> Is this the correct file? >>>>>>>>> >>>>>>>>> Regards, >>>>>>>>> Nimantha >>>>>>>>> >>>>>>>>> On Fri, Mar 23, 2012 at 9:11 PM, Ben Wolfe <[email protected]>wrote: >>>>>>>>> >>>>>>>>>> You can start from the mwb file on the wiki page as well. I >>>>>>>>>> don't know about any svg editors or if that would be easier/harder. >>>>>>>>>> >>>>>>>>>> Ben >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Fri, Mar 23, 2012 at 12:12 AM, Nimantha Baranasuriya < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Ben, >>>>>>>>>>> >>>>>>>>>>> I'll take up the task :-) >>>>>>>>>>> >>>>>>>>>>> Can I please know whether there are any tools that can be used >>>>>>>>>>> for the purpose of editing the SVG or will I need to open the MySQL >>>>>>>>>>> workbench file, edit it from there and then render the SVG? >>>>>>>>>>> >>>>>>>>>>> Regards, >>>>>>>>>>> Nimantha >>>>>>>>>>> >>>>>>>>>>> On 23 Mar, 2012, at 2:43 AM, Ben Wolfe <[email protected]> wrote: >>>>>>>>>>> >>>>>>>>>>> Any developers out there have a love for data model images? >>>>>>>>>>> Unfortunately, the last one we have done is for 1.6...and 1.9 is >>>>>>>>>>> soon to be >>>>>>>>>>> out the door. >>>>>>>>>>> https://wiki.openmrs.org/display/docs/Data+Model >>>>>>>>>>> >>>>>>>>>>> Claim this ticket if you want to make the 1.8 model. We can >>>>>>>>>>> make more tickets for 1.7 and 1.9 if you feel so inclined. :-) >>>>>>>>>>> https://tickets.openmrs.org/browse/TRUNK-2808 >>>>>>>>>>> >>>>>>>>>>> The model hasn't changed very much, so you could potentially >>>>>>>>>>> just take the 1.6 svg and modify it instead of starting from >>>>>>>>>>> scratch. The >>>>>>>>>>> 1.7.0 and 1.8.0 release notes pages should have the sql diffs on >>>>>>>>>>> them, or >>>>>>>>>>> you can look at the new entries in the >>>>>>>>>>> liquibase-update-to-latest.xml >>>>>>>>>>> file(s). >>>>>>>>>>> >>>>>>>>>>> Ben >>>>>>>>>>> ------------------------------ >>>>>>>>>>> Click here to >>>>>>>>>>> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >>>>>>>>>>> OpenMRS Developers' mailing list >>>>>>>>>>> >>>>>>>>>>> ------------------------------ >>>>>>>>>>> Click here to >>>>>>>>>>> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >>>>>>>>>>> OpenMRS Developers' mailing list >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> ------------------------------ >>>>>>>>>> Click here to >>>>>>>>>> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >>>>>>>>>> OpenMRS Developers' mailing list >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Nimantha Baranasuriya >>>>>>>>> Web: http://www.nimantha.info >>>>>>>>> Blog: http://www.nimantha.info/blog >>>>>>>>> Photography: http://www.nimantha.info/photoblog; >>>>>>>>> http://www.flickr.com/photos/nimanthab >>>>>>>>> >>>>>>>>> >>>>>>>>> ------------------------------ >>>>>>>>> Click here to >>>>>>>>> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >>>>>>>>> OpenMRS Developers' mailing list >>>>>>>>> >>>>>>>> >>>>>>>> ------------------------------ >>>>>>>> Click here to >>>>>>>> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >>>>>>>> OpenMRS Developers' mailing list >>>>>>>> >>>>>>> >>>>>>> ------------------------------ >>>>>>> Click here to >>>>>>> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >>>>>>> OpenMRS Developers' mailing list >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Nimantha Baranasuriya >>>>>> Web: http://www.nimantha.info >>>>>> Blog: http://www.nimantha.info/blog >>>>>> Photography: http://www.nimantha.info/photoblog; >>>>>> http://www.flickr.com/photos/nimanthab >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Nimantha Baranasuriya >>>>> Web: http://www.nimantha.info >>>>> Blog: http://www.nimantha.info/blog >>>>> Photography: http://www.nimantha.info/photoblog; >>>>> http://www.flickr.com/photos/nimanthab >>>>> >>>>> >>>>> ------------------------------ >>>>> Click here to >>>>> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >>>>> OpenMRS Developers' mailing list >>>>> >>>> >>>> ------------------------------ >>>> Click here to >>>> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >>>> OpenMRS Developers' mailing list >>>> >>> >>> >>> >>> -- >>> Nimantha Baranasuriya >>> Web: http://www.nimantha.info >>> Blog: http://www.nimantha.info/blog >>> Photography: http://www.nimantha.info/photoblog; >>> http://www.flickr.com/photos/nimanthab >>> >>> >>> ------------------------------ >>> Click here to >>> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >>> OpenMRS Developers' mailing list >>> >> >> ------------------------------ >> Click here to >> unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from >> OpenMRS Developers' mailing list >> > > > > -- > Nimantha Baranasuriya > Web: http://www.nimantha.info > Blog: http://www.nimantha.info/blog > Photography: http://www.nimantha.info/photoblog; > http://www.flickr.com/photos/nimanthab > > > ------------------------------ > Click here to > unsubscribe<[email protected]?body=SIGNOFF%20openmrs-devel-l>from > OpenMRS Developers' mailing list > _________________________________________ To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to [email protected] with "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
