Hi Mark, I could figure out the reason for this issue in HTML-3<https://tickets.openmrs.org/browse/HTML-3>
The reason was, in HtmlFormEntryGenerator class when the <repeat> tags are processed by applyTemplates(String xml) method, it generates a new List to keep all the <render> elements associated with the <repeat> block. When there are tables with commented out <repeat> tags in the form, those tags are also run by applyTemplates(xml) method. However the 'renderMaps' list which keeps <render> elements is empty at this occasion as loadRenderElementsForEachRepeatElement() method doesn't get any elements to add into it. When this empty list is iterated by the 'while' loop for filter out <repeat> tags from xml string it gives this exception. I created a patch and attached it in the JIRA with explanation too. I am now reading on how to add new tags into the module as it will help me to get knowledge about the first task of the project. Appreciate if you can provide me any guide :) Thanks a lot! - Ishara On Mon, Mar 26, 2012 at 8:01 PM, Mark Goodrich <[email protected]> wrote: > Ishara—**** > > ** ** > > It looks like you don’t have concept with id = 6355 in your dictionary. > When you design a sample form, you need to make sure that you reference > concepts that exist in your dictionary. Different installations create > their own custom concept dictionaries… so if you take a form created by > another installation but don’t have the same concept dictionary, the form > likely will give you the error message you are seeing below.**** > > ** ** > > You can click on the “Dictionary” link to browse your dictionary as well > as to add new concepts. You should either change the conceptIds to refer > to concepts that exist in your dictionary (the basic OpenMRS install comes > with a basic dictionary of core concepts) or create new concepts to use on > the form.**** > > ** ** > > Take care,**** > > Mark **** > > ** ** > > ** ** > > ** ** > > *From:* ishara premadasa [mailto:[email protected]] > *Sent:* Sunday, March 25, 2012 10:23 PM > *To:* Mark Goodrich > *Cc:* [email protected] > > *Subject:* Re: [GSoC 2012] Interested in 'HTML Form Entry Module > Enhancements' project**** > > ** ** > > Hi Mark, > > (I have cced this mail to the dev list also as you suggested) > > I tried to reproduce this issue in > HTML-3<https://tickets.openmrs.org/browse/HTML-3>. However when i try with > <repeat> tags in the form it gives me following > error. I think there are some incorrect syntaxes in my form code. > > *<section headerLabel="1. Patient Info"> > <repeat> > <template> > <obsgroup groupingConceptId="1295"> > <tr> > <td><obs conceptId="1297" answerConceptId="{concept}" > answerLabel="{name}" labelText=""/></td> > </tr> > </obsgroup> > </template> > > <render concept="6355" effect="James"/> > <render concept="16" effect="Anne"/> > > </repeat> > </section>* > > The error i am getting is "Cannot find concept for value 6355 in > answerConceptId attribute value. Parameters: {labelText=, > answerLabel={name}, answerConceptId=6355, conceptId=1297}". > > > I am not sure how this concept is linked with conceptId. I tried to > resolve it by referring the Tag reference > guide<https://wiki.openmrs.org/display/docs/HTML+Form+Entry+Module+HTML+Reference#HTMLFormEntryModuleHTMLReference-%3Crepeat%3E>but > couldn't find a explanation. Can you please tell me are there any > additional references i can use to get to know these tag parameters inside > <tags>? > > Thanks! > > > **** > > On Sat, Mar 24, 2012 at 2:00 AM, Mark Goodrich <[email protected]> wrote:* > *** > > Ishara—**** > > **** > > This looks like it could be a good ticket to start with… I don’t know > exactly that the issue is, so I don’t know how hard it will be to fix, so I > can’t definitely say one way or another...**** > > **** > > However, I would encourage you to explore it further. First, if you do > start to research it, make sure you claim the ticket so that others know > you are working on it. Then, see if you can reproduce the error by creating > a test form (or, even better, see if you can create a unit test that > reproduces the issue—see RegressionTest and RegressionTestHelper for some > examples of unit testing using sample forms… they aren’t that well > documented, admittedly). **** > > **** > > Finally, I’d look into how the module currently handles comments. > Honestly, I haven’t looked at that area of the code in a while, so I don’t > remember exactly what it does. HtmlFormEntryGenerator would be a good > class to start with.**** > > **** > > Good luck!**** > > Mark**** > > **** > > **** > > *From:* ishara premadasa [mailto:[email protected]] > *Sent:* Thursday, March 22, 2012 8:06 PM**** > > > *To:* Mark Goodrich > *Cc:* David Thomas**** > > *Subject:* Re: [GSoC 2012] Interested in 'HTML Form Entry Module > Enhancements' project**** > > **** > > Hi Mark, > > Thank you very much for the quick response.I did checkout the module code > and built it successfully without tests.I am now reading the project > details as well as all the info found related to this project in previous > year gsocs. Hope that i will be able to discuss with you about the project > in deep in my next mail. > > I was following your advice and searched for some introductory tickets. I > found this list <https://tickets.openmrs.org/secure/IssueNavigator.jspa?>and > would like to start on > HTML-3 <https://tickets.openmrs.org/browse/HTML-3>. However as i'm still > learning the module i am not sure what would be the best approach to do > this. Would like to know whether it is a good one to start? > > Thanks a lot! > Ishara**** > > On Thu, Mar 22, 2012 at 7:07 PM, Mark Goodrich <[email protected]> wrote:* > *** > > Ishara,**** > > **** > > Thanks for the email… sorry, I meant to reply to you yesterday before I > left work, but I got caught up in some other stuff.**** > > **** > > The HTML Form Entry module uses Git for version control and is stored at > GitHub… this is probably why you couldn’t find it. We are most likely > going to move most of the OpenMRS code/modules to Git eventually, and the > HTML Form Entry module was a first test case.**** > > The code can be found here:**** > > **** > > https://github.com/OpenMRS/openmrs-module-htmlformentry**** > > **** > > Also read the HTML Form Entry technical overview if you haven’t already > done so:**** > > **** > > > https://wiki.openmrs.org/display/docs/HTML+Form+Entry+Module+Technical+Overview > **** > > **** > > In terms of contacting the mentor vs the dev list, I would suggest that > you contact me directly, but also cc the dev list—this way I am alerted to > your question quicker (because I filter out dev list email to another > folder) but it also allows others to answer if I am unavailable for some > reason.**** > > **** > > In terms of a good ticket to take on, I would search JIRA for the HTML > Form Entry tickets in the “Ready for Work” state that have a “fix version” > of 1.9.2. These are generally smaller bug fix tickets. If you see one you > like, send me an email and I can confirm if it is a good one for you take > on…**** > > **** > > Thanks for the interest!**** > > **** > > Take care,**** > > Mark**** > > **** > > **** > > **** > > **** > > **** > > **** > > *From:* ishara premadasa [mailto:[email protected]] > *Sent:* Wednesday, March 21, 2012 2:03 PM > *To:* Mark Goodrich > *Cc:* David Thomas > *Subject:* [GSoC 2012] Interested in 'HTML Form Entry Module > Enhancements' project**** > > **** > > Hi sir, > > I am Ishara Premadasa, a final year undergraduate student from University > of Moratuwa Sri Lanka. I contacted you in the IRC today (with nickname > isharap :) ) as i am interested in contributing to 'HTML Form Entry Module > Enhancements' project for the GSoC this year. The reason why i am > interested this project is i have been worked with java, JSP, HTML and > javaScript related implementations during my internship at WSO2 last year > where i developed a web based editor <https://wso2.org/jira/browse/BPS-73>for > WSO2 BPS. However my knowledge regarding spring,hibernate frameworks > etc.is very limited as i haven't used them earlier so can you pls tell me > what are the technologies/frameworks which i need to know in prior to > involving in this project? I will use this time to getting familiar with > them. > > I did a search but couldn't find the source code of the module. Is there > any link which i can access and checkout the code? > > I have read in the project page that there are introductory tickets etc. > which can be used to getting familiar with the project. If it is not too > early i would like to work on one of these, as it will help me lot to > understand the code. I am currently reading the resources provided with the > project and researching more about it to write the proposal. > > I am grateful if you can provide me some advice on from where should i > start, what are the things to be familiar with first etc. Another thing is, > i noticed that students don't send mails to the dev list regarding their > interested GSoC project, but instead contacting the mentor directly. I > would also like to know whether this is the correct approach or should i > send a mail to dev list about my interest? > > Thank you very much in advance! > Ishara > > -- **** > > *Best Regards.***** > > **** > > *Ishara Premadasa,***** > > Final Year Undergraduate, > Dept. of Computer Science & Engineering, > University of Moratuwa > Sri Lanka.**** > > http://isharapremadasa.blogspot.com**** > > **** > > **** > > **** > > > > > -- **** > > *Best Regards.***** > > **** > > *Ishara Premadasa,***** > > Final Year Undergraduate, > Dept. of Computer Science & Engineering, > University of Moratuwa > Sri Lanka.**** > > http://isharapremadasa.blogspot.com**** > > **** > > **** > > **** > > > > > -- **** > > *Best Regards.***** > > ** ** > > *Ishara Premadasa,***** > > Final Year Undergraduate, > Dept. of Computer Science & Engineering, > University of Moratuwa > Sri Lanka.**** > > http://isharapremadasa.blogspot.com**** > > ** ** > > ** ** > > ** ** > -- *Best Regards.* *Ishara Premadasa,* Final Year Undergraduate, Dept. of Computer Science & Engineering, University of Moratuwa Sri Lanka. http://isharapremadasa.blogspot.com _________________________________________ To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to [email protected] with "SIGNOFF openmrs-devel-l" in the body (not the subject) of your e-mail. [mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
