Thanks, Wyclif. I will try to attend.
Thanks,
Tammy
On 3/29/2012 12:53 PM, Wyclif Luyima wrote:
Hi Tammy,
We talked about your concerns on todays dev call.
For issue2, it is the calculation evaluators that are singletons not
calculations/rules.
We will be having more discussions on the design call next week
on Wednesday at 2pm ET and you are welcome call to attend.
Wyclif
On Thu, Mar 29, 2012 at 11:05 AM, Tammy Dugan <[email protected]
<mailto:[email protected]>> wrote:
There were two major issues that came up when reviewing the
changes with Wyclif,
1. Logic cannot hit the database for every token lookup. This is
an unacceptable performance hit for a system like chica. The
tokens need to be cached.
2. Rules should not be singletons. Making them singletons is
non-thread safe and requires special programming that is not
intuitive to the naive programmer. A new instance should be
created each time.
I also want to point out that we have fixed #2 twice already in
previous versions and now it needs to be fixed for a third time.
Also, #1 was fixed in the previous version and now has to be fixed
again. It gets frustrating that these same problems keeps getting
reintroduced each time logic is refactored and each time I have to
make the case about why it should be that way and we have to fix
the problem. It is important when refactoring to preserve the old
behavior!
Because of these issues, we have no immediate plans to update
chica to use the new version of logic with Calculations. It took
us months to get things working before and we just don't have the
programming resources to do it now or in the near future.
Thanks,
Tammy Dugan
On 3/29/2012 10:08 AM, Friedman, Roger (CDC/CGH/DGHA) (CTR) wrote:
It appears that trunk produces 0.5.3 which includes Calculation,
last branch is 0.5.1 which is not mavenized, 0.5.2 is mavenized,
can it be a branch even if not released?
*From:*[email protected] <mailto:[email protected]>
[mailto:[email protected]] *On Behalf Of *Wyclif Luyima
*Sent:* Friday, March 23, 2012 3:53 PM
*To:* [email protected]
<mailto:[email protected]>
*Subject:* [OPENMRS-DEV] Calculation sprint wrap up
Hi everyone,
For the past 2 weeks, we have been having a sprint on the
calculation module plus making logic and reporting to expose
themselves as calculations. We managed to get all the 27 tickets
specific to the module done by Wednesday. Some work has been done
to retrofit logic and reporting to be exposed as calculations, i
went through the changes in logic with Tammy and Win this
afternoon, Tammy had some interesting points of discussion which
i believe she will send on the dev list.
In general, the code looks pretty good and i think we are ready
for its 1.0 release which could be in the next 1 -2 weeks,
apparently we have to wait for final high level reviews from
Darius and Burke as contributors to its design to confirm if it
is actually what they envisioned.
The sprinter turn up was good which included the core developers,
Mike and Mykola, thank you all for your relentless work.
Have a great weekend.
Wyclif
------------------------------------------------------------------------
Click here to unsubscribe
<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l>
from OpenMRS Developers' mailing list
------------------------------------------------------------------------
Click here to unsubscribe
<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l>
from OpenMRS Developers' mailing list
--
Tammy Dugan
CHIRDL Technical Lead
Children's Health Services Research
IU School of Medicine
------------------------------------------------------------------------
Click here to unsubscribe
<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l> from
OpenMRS Developers' mailing list
------------------------------------------------------------------------
Click here to unsubscribe
<mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l>
from OpenMRS Developers' mailing list
--
Tammy Dugan
CHIRDL Technical Lead
Children's Health Services Research
IU School of Medicine
_________________________________________
To unsubscribe from OpenMRS Developers' mailing list, send an e-mail to
[email protected] with "SIGNOFF openmrs-devel-l" in the body (not
the subject) of your e-mail.
[mailto:[email protected]?body=SIGNOFF%20openmrs-devel-l]
