Sorry for the long delay. I am back to this issue now. Checking the code I found out that the constructors of the factories that have arguments are used all over the code to create factories using the API. For example, while training when we don't have the artifact provider yet, and we need to create the factory programmatically.
On Tue, Jul 17, 2012 at 9:33 AM, Jörn Kottmann <kottm...@gmail.com> wrote: > On 07/14/2012 05:35 AM, William Colen wrote: > >> I think it is better now, but I am not happy with the fact that we have >> two >> constructors in each tool factory. >> I will think how to get rid of the constructors that takes the same >> arguments of the method init. I would appreciate if you have an opinion >> about it. >> > > Usually the init method will not be called by user code. So only OpenNLP > code calls this once after the factory is created. > > I think we should document this in the javadoc of the class and remove > the constructor which takes the arguments we now pass in via the init > method. > > Jörn > >
