sounds good, I will get it in the sandbox...
On Tue, Nov 5, 2013 at 8:43 AM, Jörn Kottmann <[email protected]> wrote: > On 11/05/2013 01:23 PM, Mark G wrote: > >> Joern, I am using Lucene inside the GeoEntityLinker impl, so do you think >> I >> should move the entire GeoEntityLinker impl and all its classes to a new >> module in the sandbox and leave only the entitylinker framework in opennlp >> tools? >> > > +1, it might be nice to provide a simple dictionary based implementation > as a sample for simple > tasks, e.g. just map country names. > If the user wants to use the lucene based solution he should just depend > on the addon module, which > we should release together with the core components. > > > A second thought/option is to make the lucene pom entries optional in the >> opennlptools pom, so users will have to add lucene to their pom to run the >> geoentitylinker and the jars will not be included in the tools build >> > > I really prefer the other solution because then a user needs to once > explicitly deal with it > to make his project work, if you do this people probably start using the > clases and then discover > only by try and error that there must be something missing on their > classpath. > > The lemmatizer will also be part of the addon solution, if there are no > concerns I suggest we get our > addons started. > > Jörn >
