Hi Joern, I’m confused. Why did you revert my commit?
Every one of those check points you put on the PR was checked? We have been discussing this for months, you have seen the code for months, Ana and I have worked diligently on the code in plain view of everyone. Please explain. Chris On 6/27/17, 1:23 AM, "kottmann" <[email protected]> wrote: GitHub user kottmann opened a pull request: https://github.com/apache/opennlp/pull/238 Revert merging of sentiment work, no consent to merge it Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kottmann/opennlp revert_sentiment Alternatively you can review and apply these changes as the patch at: https://github.com/apache/opennlp/pull/238.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #238 ---- commit 123222eb34724bae793e9d6d22e202c0aee0aa45 Author: Jörn Kottmann <[email protected]> Date: 2017-06-27T08:19:19Z Revert merging of sentiment work, no consent to merge it ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at [email protected] or file a JIRA ticket with INFRA. ---
