kinow commented on a change in pull request #377:
URL: https://github.com/apache/opennlp/pull/377#discussion_r435686123
##########
File path:
opennlp-tools/src/test/java/opennlp/tools/eval/SourceForgeModelEval.java
##########
@@ -410,7 +410,7 @@ public void evalParserModel() throws Exception {
}
}
- Assert.assertEquals(new
BigInteger("312218841713337505306598301082074515847"),
+ Assert.assertEquals(new
BigInteger("68039262350771988792233880373220954061"),
Review comment:
The change of precision in the other tests was small compared to this
one. This was the only thing that got my eye from reading the changes here.
Pretty much everything else appears to be just s/Math/StrictMath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
