jzonthemtn opened a new pull request #395: URL: https://github.com/apache/opennlp/pull/395
This is a large pull request. There are no functional changes. The changes in this pull request abstract out OpenNLP's interfaces into a new project called `opennlp-common`. The implementation of those interfaces stay in `opennlp-tools`. Applications that use OpenNLP should not require any changes as a result of this pull request. The purpose is to support deep learning frameworks. New NLP implementations can implement the existing OpenNLP interfaces. It also keeps dependencies separate and not required between implementations. This change is illustrated here: https://cwiki.apache.org/confluence/display/OPENNLP/OpenNLP+2.x It is my goal that after this refactoring, the project can start working toward deep learning implementation for OpenNLP 2.0 by starting to implement those interfaces - Unit tests pass and the evaluation tests will also be run prior to merge. - There may be some whitespace changes and import reodering due to addressing checkstyle warnings. ------ Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? - [X] Is your initial contribution a single, squashed commit? ### For code changes: - [X] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder? - [X] Have you written or updated unit tests to verify your changes? - [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [X] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder? - [X] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder? ### For documentation related changes: - [X] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
