rzo1 commented on code in PR #479:
URL: https://github.com/apache/opennlp/pull/479#discussion_r1060164388
##########
opennlp-uima/src/main/java/opennlp/uima/normalizer/NumberUtil.java:
##########
@@ -52,31 +51,36 @@ public static boolean isLanguageSupported(String
languageCode) {
}
/**
- * Removes trailing and containing space.
+ * Removes a character from given string {@code s}.
+ *
+ * @param s The string to process.
+ * @param remove The {@link Character} to remove from {@code s}.
*/
- private static String removeChar(String string, char remove) {
+ private static String removeChar(String s, char remove) {
Review Comment:
Alternative: As the method is `private` and only used for removing `' '`
from a given String, we could avoid dealing with the [hell of
whitespace](https://en.wikipedia.org/wiki/Whitespace_character) andjust replace
it with a call to `s.replaceAll("\\s+", "");` ?
##########
opennlp-uima/src/main/java/opennlp/uima/normalizer/NumberUtil.java:
##########
@@ -52,31 +51,36 @@ public static boolean isLanguageSupported(String
languageCode) {
}
/**
- * Removes trailing and containing space.
+ * Removes a character from given string {@code s}.
+ *
+ * @param s The string to process.
+ * @param remove The {@link Character} to remove from {@code s}.
*/
- private static String removeChar(String string, char remove) {
+ private static String removeChar(String s, char remove) {
Review Comment:
Alternative: As the method is `private` and only used for removing `' '`
from a given String, we could avoid dealing with the [hell of
whitespace](https://en.wikipedia.org/wiki/Whitespace_character) and just
replace it with a call to `s.replaceAll("\\s+", "");` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
