rzo1 commented on code in PR #58:
URL: https://github.com/apache/opennlp-sandbox/pull/58#discussion_r1082222656
##########
opennlp-coref/pom.xml:
##########
@@ -25,20 +25,20 @@
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
- <version>13</version>
+ <version>18</version>
Review Comment:
29?
##########
opennlp-coref/src/main/java/opennlp/tools/coref/resolver/AbstractResolver.java:
##########
@@ -169,7 +170,14 @@ public DiscourseEntity retain(MentionContext mention,
DiscourseModel dm) {
DiscourseEntity cde = dm.getEntity(ei);
MentionContext cec = cde.getLastExtent(); // candidate extent context
if (cec.getId() == mention.getId()) {
- distances.add(ei);
+ // adding counts
+ Integer count = distances.get(ei);
Review Comment:
`distances.merge(e, 1, Integer::sum)` ?
##########
opennlp-coref/src/main/java/opennlp/tools/coref/resolver/MaxentResolver.java:
##########
@@ -286,7 +294,14 @@ public DiscourseEntity retain(MentionContext mention,
DiscourseModel dm) {
events.add(new Event(SAME, features.toArray(new
String[features.size()])));
de = cde;
//System.err.println("MaxentResolver.retain: resolved at "+ei);
- distances.add(ei);
+ // adding counts
+ Integer count = distances.get(ei);
Review Comment:
`distances.merge(e, 1, Integer::sum)` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
