mawiesne commented on code in PR #506:
URL: https://github.com/apache/opennlp/pull/506#discussion_r1118109618
##########
opennlp-tools/src/main/java/opennlp/tools/tokenize/lang/Factory.java:
##########
@@ -25,24 +25,45 @@
public class Factory {
- public static final String DEFAULT_ALPHANUMERIC = "^[A-Za-z0-9]+$";
+ public static final Pattern DEFAULT_ALPHANUMERIC =
Pattern.compile("^[A-Za-z0-9]+$");
Review Comment:
Others might reference this. That's why I left its visibility untouched.
Even though the type changed to Pattern, the original form can easily be
accessed via `.pattern()` which returns it as a String.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
