Re: [PR] OPENNLP-1515: Changing onnx dependency to onnxruntime. (opennlp)

[via GitHub]

rzo1 commented on PR #551:
URL: https://github.com/apache/opennlp/pull/551#issuecomment-1759590853

   Something like:
   
   ```bash
   
   <project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
     <modelVersion>4.0.0</modelVersion>
     <parent>
       <groupId>org.apache.opennlp</groupId>
       <artifactId>opennlp</artifactId>
       <version>2.3.1-SNAPSHOT</version>
       <relativePath>../pom.xml</relativePath>
     </parent>
     <groupId>org.apache.opennlp</groupId>
     <artifactId>opennlp-dl</artifactId>
     <name>Apache OpenNLP DL</name>
   
     <properties>
       <onxx-runtime.artifact.name>onnxruntime_gpu</onxx-runtime.artifact.name>
     </properties>
   
     <profiles>
       <profile>
         <id>system-osx</id>
         <activation>
           <os>
             <family>mac</family>
           </os>
         </activation>
         <properties>
           <onxx-runtime.artifact.name>onnxruntime</onxx-runtime.artifact.name>
         </properties>
       </profile>
     </profiles>
   
     <dependencies>
       <dependency>
         <groupId>org.apache.opennlp</groupId>
         <artifactId>opennlp-tools</artifactId>
         <version>${project.version}</version>
       </dependency>
       <dependency>
         <groupId>com.microsoft.onnxruntime</groupId>
         <artifactId>${onxx-runtime.artifact.name}</artifactId>
         <version>${onnxruntime.version}</version>
       </dependency>
       <dependency>
         <groupId>org.slf4j</groupId>
         <artifactId>slf4j-api</artifactId>
       </dependency>
       <dependency>
         <groupId>org.junit.jupiter</groupId>
         <artifactId>junit-jupiter-api</artifactId>
         <scope>test</scope>
       </dependency>
       <dependency>
         <groupId>org.junit.jupiter</groupId>
         <artifactId>junit-jupiter-engine</artifactId>
         <scope>test</scope>
       </dependency>
       <dependency>
         <groupId>org.slf4j</groupId>
         <artifactId>slf4j-simple</artifactId>
         <scope>test</scope>
       </dependency>
     </dependencies>
   </project>
   ```
   
   Think it would propagate for the transient dependencies as well but would 
need special treatment for building the zip releases (ie. include both libs)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org