rzo1 commented on code in PR #561:
URL: https://github.com/apache/opennlp/pull/561#discussion_r1419047800


##########
opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/SnowballStemmer.java:
##########
@@ -21,116 +21,94 @@
 
 public class SnowballStemmer implements Stemmer {
 
-  public enum ALGORITHM {
-    ARABIC,
-    DANISH,
-    DUTCH,
-    CATALAN,
-    ENGLISH,
-    FINNISH,
-    FRENCH,
-    GERMAN,
-    GREEK,
-    HUNGARIAN,
-    INDONESIAN,
-    IRISH,
-    ITALIAN,
-    NORWEGIAN,
-    PORTER,
-    PORTUGUESE,
-    ROMANIAN,
-    RUSSIAN,
-    SPANISH,
-    SWEDISH,
-    TURKISH
-  }
+    private final AbstractSnowballStemmer stemmer;

Review Comment:
   Why does checkstyle not complain Here? 



##########
opennlp-tools/src/main/java/opennlp/tools/stemmer/snowball/SnowballStemmer.java:
##########
@@ -21,116 +21,94 @@
 
 public class SnowballStemmer implements Stemmer {
 
-  public enum ALGORITHM {
-    ARABIC,
-    DANISH,
-    DUTCH,
-    CATALAN,
-    ENGLISH,
-    FINNISH,
-    FRENCH,
-    GERMAN,
-    GREEK,
-    HUNGARIAN,
-    INDONESIAN,
-    IRISH,
-    ITALIAN,
-    NORWEGIAN,
-    PORTER,
-    PORTUGUESE,
-    ROMANIAN,
-    RUSSIAN,
-    SPANISH,
-    SWEDISH,
-    TURKISH
-  }
+    private final AbstractSnowballStemmer stemmer;

Review Comment:
   Why does checkstyle not complain here? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to