mawiesne commented on PR #559: URL: https://github.com/apache/opennlp/pull/559#issuecomment-1846627276
> Do you want me to extract the common code into a helper method? @l-ma Yes, that would be preferable. Reusing the very same code is a good thing. If you can refactor existing test code, as mentioned, which fits the scope of the issue, feel free to apply refactoring and extract it to helper methods. But: don't over-engineer things. It's always okay to open a new Jira to allow focus on other topics / parts of the code. Thx again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
