mawiesne commented on PR #568: URL: https://github.com/apache/opennlp/pull/568#issuecomment-1858750219
I think, we c/should consider using a `ConcurrentHashMap`-based deduplicator approach as a replacement for "intern()" calls, as investigated and explained by Shipilev in his blog post here: https://shipilev.net/jvm/anatomy-quarks/10-string-intern/ The removal of the String deduplication, as found in the code segments of this PR, could otherwise lead to more required RAM at runtime - as @kinow already expressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
