rzo1 commented on code in PR #568: URL: https://github.com/apache/opennlp/pull/568#discussion_r1429734990
########## opennlp-tools/src/main/java/opennlp/tools/util/jvm/StringInterners.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package opennlp.tools.util.jvm; + +import java.lang.reflect.Constructor; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Provides string interning utility methods. Interning mechanism can be configured via the + * system property {@code opennlp.interner.class} by specifying an implementation via its + * full qualified classname. It needs to implement {@link StringInterner}. + * <p> + * If not specified by the user, the default interner is {@link CHMStringInterner}. + */ +public class StringInterners { + + private static final Logger LOGGER = LoggerFactory.getLogger(StringInterners.class); + private static final StringInterner INTERNER; + + static { + + final String clazzName = System.getProperty("opennlp.interner.class", Review Comment: ```java final String clazzName = System.getProperty("opennlp.interner.class", CHMStringInterner.class.getCanonicalName()); ``` uses ```java /** * Gets the system property indicated by the specified key. * * First, if there is a security manager, its * {@code checkPropertyAccess} method is called with the * {@code key} as its argument. * <p> * If there is no current set of system properties, a set of system * properties is first created and initialized in the same manner as * for the {@code getProperties} method. * * @param key the name of the system property. * @param def a default value. * @return the string value of the system property, * or the default value if there is no property with that key. * * @throws SecurityException if a security manager exists and its * {@code checkPropertyAccess} method doesn't allow * access to the specified system property. * @throws NullPointerException if {@code key} is {@code null}. * @throws IllegalArgumentException if {@code key} is empty. * @see #setProperty * @see java.lang.SecurityManager#checkPropertyAccess(java.lang.String) * @see java.lang.System#getProperties() */ public static String getProperty(String key, String def) ``` which will return `CHMStringInterner.class.getCanonicalName()` if the property `opennlp.interner.class` is not defined. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
