rzo1 opened a new pull request, #572:
URL: https://github.com/apache/opennlp/pull/572
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
This PR is a follow-up for OPENNLP-421 to remove unnecessary object creation
by removing `StringListWrapper` used in `Dictionary`.
The sole purpose of the `StringListWrapper` impl was to provide a way to
ignore cases for dictionary entries stored in a `StringList` by overriding the
related `hashCode()` and `equals(...)` method.
This PR delegates the behaviour to the actual `StringList` and adds methods
to "convert" the behaviour from a case-sensitive `StringList` to its
insensitive form.
By doing so, we can reduce the creation of objects for `contains(...)`,
`add(...)`, etc. operation. We only create new `StringLists` if their case does
not match the case of the dictionary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
