kinow commented on code in PR #113:
URL: https://github.com/apache/opennlp-sandbox/pull/113#discussion_r1436543081
##########
opennlp-wsd/src/test/java/opennlp/tools/disambiguator/WSDTest.java:
##########
@@ -47,95 +46,62 @@
* and then the computed model is used to predict sentences
* from the training sentences.
*/
-
-class WSDTester {
- // TODO write more tests
- // TODO modify when we fix the parameter model
-
- static String modelsDir = "src/test/resources/models/";
- static String trainingDataDirectory =
"src/test/resources/supervised/models/";
+// TODO write more tests
+// TODO modify when we fix the parameter model
Review Comment:
:+1: :point_up:
##########
corpus-server/corpus-server-connector/src/test/java/org/apache/opennlp/corpus_server/connector/CSCasWriterTest.java:
##########
@@ -77,7 +76,6 @@ void testCasWrite() {
cas.setDocumentText("this cas needs to be stored");
casConsumer.processCas(cas);
} catch (Exception e) {
- e.printStackTrace();
Review Comment:
:+1:
##########
summarizer/src/test/java/opennlp/summarization/lexicalchaining/LexChainTest.java:
##########
@@ -101,7 +102,7 @@ void testGetRelation() {
assertEquals(WordRelation.MED_RELATION, rel2.relation);
assertEquals(WordRelation.MED_RELATION, rel3.relation);
} catch (Exception e) {
- e.printStackTrace();
+ fail(e.getLocalizedMessage());
Review Comment:
:+1: or just let it raise the exception with the whole stack trace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
