mawiesne opened a new pull request, #748: URL: https://github.com/apache/opennlp/pull/748
Change - - adapts and reactivates `AnnotatorsInitializationTest` by T. Teofili, originally provided in JIRA issue, to execute for all xml descriptors via true ITs - converts AnnotatorsInitializationTest to several integration tests executed via Maven failsafe plugin - adds `Parser.xml` to _test-descriptors_ - adds more test classes to _uima_ component - configures Maven resource filtering for xml _test-descriptors_ - moves 'ci' profile to upper-level pom.xml for re-use in _uima_ component - adds _simplelogger.properties_ to test resources dir to avoid log spam during build caused by internal UIMA logger config - adds missing `@Override` annotations here and there - reorganizes properties section of parent pom.xml, adding comments Code Coverage (with PR) - <img width="750" alt="CodeCov-withPR" src="https://github.com/user-attachments/assets/058b7bf6-f3bc-4019-be7c-74a292b9abd0"; /> Code Coverage (previously / without PR) - <img width="750" alt="CodeCov-withoutPR" src="https://github.com/user-attachments/assets/5937c43b-8304-4b95-acde-06ac77c86ec2"; /> Tasks - Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
