NishantShri4 commented on code in PR #758: URL: https://github.com/apache/opennlp/pull/758#discussion_r2056098821
########## opennlp-tools/src/test/java/opennlp/tools/ml/TrainerFactoryTest.java: ########## @@ -78,4 +83,15 @@ void testIsSequenceTrainerFalse() { Assertions.assertNotEquals(TrainerType.EVENT_MODEL_SEQUENCE_TRAINER, trainerType); } + @Test + void testGetEventTrainerConfiguration() { + mlParams.put(TrainingParameters.ALGORITHM_PARAM, GISTrainer.MAXENT_VALUE); + + TrainingConfiguration config = new TrainingConfiguration(new DefaultTrainingProgressMonitor(), + new LogLikelihoodThresholdBreached(mlParams)); + + AbstractTrainer trainer = (AbstractTrainer)TrainerFactory.getEventTrainer(mlParams, null, config); + assertTrue(trainer.getTrainingConfiguration().progMon() instanceof DefaultTrainingProgressMonitor); Review Comment: Thanks. Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org