mawiesne commented on code in PR #758: URL: https://github.com/apache/opennlp/pull/758#discussion_r2058602487
########## opennlp-tools/src/main/java/opennlp/tools/commons/Trainer.java: ########## @@ -35,4 +36,14 @@ public interface Trainer { */ void init(TrainingParameters trainParams, Map<String, String> reportMap); + /** + * Conducts the initialization of a {@link Trainer} via + * {@link TrainingParameters}, {@link Map report map} and {@link TrainingConfiguration} + * + * @param trainParams The {@link TrainingParameters} to use. + * @param reportMap The {@link Map} instance used as report map. + * @param config The {@link TrainingConfiguration} to use. Review Comment: Thx for reporting back on this - I now better see the case for `null` as trainer configuration. The JavaDoc is for that seems helpful and clarifies that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org