rzo1 commented on code in PR #812:
URL: https://github.com/apache/opennlp/pull/812#discussion_r2192024611
##########
opennlp-core/opennlp-runtime/src/main/java/opennlp/tools/lemmatizer/ThreadSafeLemmatizerME.java:
##########
@@ -20,25 +20,27 @@
import java.util.List;
import opennlp.tools.commons.ThreadSafe;
+import opennlp.tools.ml.Probabilistic;
/**
* A thread-safe version of the {@link LemmatizerME}. Using it is completely
transparent.
* You can use it in a single-threaded context as well, it only incurs a
minimal overhead.
- *
- * @implNote
+ * <p>
Review Comment:
p should be closed, no?
##########
opennlp-core/opennlp-runtime/src/main/java/opennlp/tools/postag/ThreadSafePOSTaggerME.java:
##########
@@ -20,28 +20,31 @@
import java.io.IOException;
import opennlp.tools.commons.ThreadSafe;
+import opennlp.tools.ml.Probabilistic;
import opennlp.tools.models.ModelType;
import opennlp.tools.util.DownloadUtil;
import opennlp.tools.util.Sequence;
/**
* A thread-safe version of the {@link POSTaggerME}. Using it is completely
transparent.
* You can use it in a single-threaded context as well, it only incurs a
minimal overhead.
- *
- * @implNote
+ * <p>
+ * <b>Note:</b><br/>
Review Comment:
see above
##########
opennlp-core/opennlp-runtime/src/main/java/opennlp/tools/sentdetect/ThreadSafeSentenceDetectorME.java:
##########
@@ -21,28 +21,31 @@
import opennlp.tools.commons.ThreadSafe;
import opennlp.tools.dictionary.Dictionary;
+import opennlp.tools.ml.Probabilistic;
import opennlp.tools.models.ModelType;
import opennlp.tools.util.DownloadUtil;
import opennlp.tools.util.Span;
/**
* A thread-safe version of {@link SentenceDetectorME}. Using it is completely
transparent.
* You can use it in a single-threaded context as well, it only incurs a
minimal overhead.
- *
- * @implNote
+ * <p>
+ * <b>Note:</b><br/>
Review Comment:
see above
##########
opennlp-core/opennlp-runtime/src/main/java/opennlp/tools/tokenize/ThreadSafeTokenizerME.java:
##########
@@ -21,28 +21,31 @@
import opennlp.tools.commons.ThreadSafe;
import opennlp.tools.dictionary.Dictionary;
+import opennlp.tools.ml.Probabilistic;
import opennlp.tools.models.ModelType;
import opennlp.tools.util.DownloadUtil;
import opennlp.tools.util.Span;
/**
* A thread-safe version of {@link TokenizerME}. Using it is completely
transparent.
* You can use it in a single-threaded context as well, it only incurs a
minimal overhead.
- *
- * @implNote
+ * <p>
+ * <b>Note:</b><br/>
Review Comment:
see above
##########
opennlp-core/opennlp-runtime/src/main/java/opennlp/tools/langdetect/ThreadSafeLanguageDetectorME.java:
##########
@@ -22,15 +22,16 @@
/**
* A thread-safe version of the {@link LanguageDetectorME}. Using it is
completely transparent.
* You can use it in a single-threaded context as well, it only incurs a
minimal overhead.
- *
- * @implNote
+ * <p>
Review Comment:
see above
##########
opennlp-core/opennlp-runtime/src/main/java/opennlp/tools/namefind/ThreadSafeNameFinderME.java:
##########
@@ -18,26 +18,28 @@
package opennlp.tools.namefind;
import opennlp.tools.commons.ThreadSafe;
+import opennlp.tools.ml.Probabilistic;
import opennlp.tools.util.Span;
/**
* A thread-safe version of {@link NameFinderME}. Using it is completely
transparent.
* You can use it in a single-threaded context as well, it only incurs a
minimal overhead.
- *
- * @implNote
+ * <p>
Review Comment:
see above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
