rzo1 commented on code in PR #892:
URL: https://github.com/apache/opennlp/pull/892#discussion_r2538015445
##########
opennlp-tools/src/main/java/opennlp/tools/util/XmlUtil.java:
##########
@@ -38,7 +38,11 @@ public class XmlUtil {
public static DocumentBuilder createDocumentBuilder() {
try {
DocumentBuilderFactory documentBuilderFactory =
DocumentBuilderFactory.newInstance();
-
documentBuilderFactory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
+ try {
+
documentBuilderFactory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
+ } catch (ParserConfigurationException ignored) {
Review Comment:
Can we at least log the exception, so it is clear that the feature is
unsupported? (also add a comment targeting to the relevant android javadoc as
you did in the PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
