rzo1 opened a new pull request, #1057:
URL: https://github.com/apache/opennlp/pull/1057

   Add a native, language-agnostic spell-correction component backed by the 
[SymSpell](https://github.com/wolfgarbe/SymSpell) (Symmetric Delete) algorithm 
as a new opennlp-spellcheck module under opennlp-extensions.
   
   ---
   
   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via mvn 
clean install at the root opennlp folder?
   - [x] Have you written or updated unit tests to verify your changes?
   - [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file in opennlp folder?
   - [x] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [x] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   
   I have updated with the data needed to run some eval tests: 
https://nightlies.apache.org/opennlp/opennlp-data.zip
   In addition, this PR does not ship pre-build dictionaries (1-gram, 2-gram). 
Idea would be to put some default dicts for the major language together via 
https://github.com/apache/opennlp-models (or a like).
   
   Currently, this is a draft to get some feedback since I am going to do a few 
more review passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to