krickert commented on PR #1072: URL: https://github.com/apache/opennlp/pull/1072#issuecomment-4680968979
Thanks and addressed: **1. Release notes:** The breaking change is now documented in three places: the PR body, a **Release Note** paragraph on the OPENNLP-1836 JIRA (please paste the text below into the JIRA Release Note field), and the `SentenceVectorsDL` class Javadoc (`Release note (OpenNLP 3.0.0)` paragraph in commit 33b15e4f). Targeting 3.0.0, not a patch release. **2. DocumentCategorizerDL follow-up:** Filed as OPENNLP-1839 (leak + vocab-miss handling; 2.x backport of leak/error-handling only to discuss there). **Copilot:** `assertEquals` argument order was already corrected in 15fc495a. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
