krickert commented on PR #1075: URL: https://github.com/apache/opennlp/pull/1075#issuecomment-4694708476
Thanks @rzo1 @mawiesne. Eval build #48 didn't actually exercise the new DL evals. `opennlp-eval-tests` sets surefire `<skip>true</skip>` in the base build config, and the `eval-tests` profile adds includes but never overrides the skip - so the module compiles the eval sources and runs nothing. You can see it in the build log: the module finishes in ~1.2s and no `*DLEval` class appears anywhere in the console output. The 53 minutes of eval work all happened in the classic suites. This also means the `DocumentCategorizerDLEval` pin shift described in the PR text has not been observed by CI yet. It turns out the doccat ONNX eval models *are* in the nightlies eval data (`onnx/doccat/`), so I'm running the DL evals locally against it right now and will push the regenerated pinned values to this branch shortly - please hold off merging until that commit lands. The surefire skip issue itself is a pre-existing bug on `main` (it affects every eval class in the module, not just the DL ones). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
