krickert opened a new pull request, #1084:
URL: https://github.com/apache/opennlp/pull/1084
Make NameFinderDL, DocumentCategorizerDL and SentenceVectorsDL safe to share
across threads, so a single instance (and its loaded ONNX session) can serve
concurrent requests instead of being duplicated or externally synchronized.
Inference already held no per-call instance state and OrtSession.run is
concurrency-safe; the gaps were safe publication and a shared-resource leak:
- AbstractDL now assigns its env/session/tokenizer/vocab once through a
protected constructor and marks them final, guaranteeing safe publication of a
fully constructed instance. The subclass constructors delegate to it.
- Defensive-copy the ids2Labels and categories maps so external mutation
cannot race with inference.
- close() no longer closes the process-wide OrtEnvironment singleton (shared
by every DL component); it closes only the session this instance owns.
- The vocabulary and tokenizer factory helpers (loadVocab, createTokenizer)
become static, reflecting that they use no instance state.
- Annotate the three components @ThreadSafe. NameFinderDL is thread-safe
provided the injected SentenceDetector is (e.g. SentenceDetectorME).
Add a concurrent NameFinderDL eval test that runs find() from many threads
on one shared instance and asserts every result matches the single-threaded
case.
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
