rzo1 commented on PR #1110: URL: https://github.com/apache/opennlp/pull/1110#issuecomment-4799034229
- Loader symmetry: `WordBreakProperty.parse` fails loud on a missing `;`, while `ExtendedPictographic.parse` silently treats a line with no `;` as whole-content, and only the former has a malformed-data/missing-resource test. Worth making the two read and test alike. - `WordType.of` fixes a token's script from its first script code point only; fine for single-script UAX#29 segments but a heuristic for mixed-script runs. A one-line javadoc note would help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
