krickert commented on PR #1111:
URL: https://github.com/apache/opennlp/pull/1111#issuecomment-4802831017
@rzo1 All three addressed (tip `a23a5135`).
**`dashes()` → `dash()`.** Renamed both overloads on `TermAnalyzer.Builder`
for consistency with the singular layer-enable methods and the `DASH` enum.
(`TextNormalizer.Builder.dashes()` keeps the plural — there it sits among
`quotes()`/`digits()`/`bullets()`, so plural is the consistent choice in *that*
class.) No callers needed updating.
**Dangling `searchAnalyzer()` link.** Softened the class-javadoc `{@link
NormalizationProfile#searchAnalyzer()}` to `{@code
NormalizationProfile.searchAnalyzer()}`, so 2b carries no dangling link to a
type that lands in #1112.
**`analyze(CharSequence)` + eager LEMMA.** Clarified the doc and kept the
fail-loud throw rather than silently skipping the layer.
`analyze(CharSequence)` has no POS tags, so a configured LEMMA layer genuinely
can't be computed from that entry point; silently dropping it would hide a
misconfiguration (a lemmatizer was configured but never runs). The javadoc now
states it throws when a lemmatizer is configured and points to `analyze(tokens,
tags)` for the lemma path. Added
`testAnalyzeCharSequenceFailsLoudlyWhenLemmaConfigured` covering it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
