rzo1 commented on PR #1120: URL: https://github.com/apache/opennlp/pull/1120#issuecomment-4809305290
Good catch on the mechanics — you're right that `needs: build` waits on the whole 6-leg matrix, so if any leg fails the shell-test jobs get skipped. But that's actually the behavior I want here, and it ties into the whole point of this PR. The goal is to cut CI load so we don't pile up queues when several PRs hit at once. Today the distribution gets built 9× per run (6 in `maven.yml` + 3 in `shell-tests.yml`); this PR drops that to building it once on Linux/JDK 21 and reusing the artifact. Gating the shell tests on a fully-green matrix fits the same intent: if any build leg is red, the run is already failing, so spinning up three more OS runners to shell-test a build we know is broken just burns minutes we're trying to save. The skip can't ever mask a failure — it never turns a red run green — so we lose nothing on the safety side; we only skip shell coverage on a run that's already failing for another reason. Your `build-distribution` job idea would decouple it, but I'd rather not: it adds a runner back and would let shell tests go green while the main matrix is red, which is a more confusing signal than a clean skip. Thanks for the careful review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
