vasiliy-mikhailov commented on PR #1135:
URL: https://github.com/apache/opennlp/pull/1135#issuecomment-4859748174
Thanks @rzo1, both good catches.
On the duplicate: `testCompatibilityContinueWithoutStartOrLast` now uses
`{B_CONTINUE, A_UNIT}` instead of the same `{B_CONTINUE, B_LAST, B_UNIT}` as
`testCompatibilityContinueWithoutStart`, so it actually reaches the
cont-with-no-matching-start-or-last branch you pointed to (rather than
short-circuiting in the last-validation loop); the assertion stays
incompatible. It is now a genuinely distinct case.
On the line-number comments: already handled in an earlier follow-up. I
dropped the literal `line 178` / `lines 99-105` references from the Javadoc and
reworded them to name the branch/behaviour under test, since they would rot as
`BilouCodec` shifts (and, as you noted, `testCompatibilityContinueWithoutStart`
short-circuits in the last-validation loop, not the cont loop I had cited).
Full test class stays green after both changes (81 tests). Thanks again for
the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
