krickert opened a new pull request, #1162: URL: https://github.com/apache/opennlp/pull/1162
Thank you for contributing to Apache OpenNLP. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ## What is this PR for? OPENNLP-997 (2017) excluded `**/stemmer/*` and `**/stemmer/snowball/*` from the JaCoCo coverage report to keep generated Snowball code out of coverage metrics. The same excludes were also copied into the surefire configuration (root pom plus opennlp-tools, opennlp-runtime, opennlp-cli, opennlp-formats), so no test under a stemmer package has run in any Maven build since. This hid a stale test: OPENNLP-1701 regenerated the Snowball code, whose Turkish algorithm now removes proper-noun suffixes after an apostrophe (`r_remove_proper_noun_suffix`), and `SnowballStemmerTest#testTurkish` still expected the old behavior. The updated expectations follow the snowball-data reference vocabulary. ## Changes - Remove the stemmer excludes from surefire in five poms (the JaCoCo report excludes are kept, so coverage metrics are unchanged) - Update `SnowballStemmerTest#testTurkish` to the current reference behavior (`ab'yle` -> `ab`, `sarayı'nı` -> `sara`) This unhides 26 existing stemmer tests. The full reactor build (`mvn clean test verify -Pjacoco -Pci`) passes with them enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
