Hi Damjan,
On 11/9/12 5:13 AM, Damjan Jovanovic wrote: > Hi all > > Can you please help review my patch > (https://issues.apache.org/ooo/attachment.cgi?id=79884) to > bug 112064 (https://issues.apache.org/ooo/show_bug.cgi?id=112064)? > thanks for your patch, it is a very good addition to close the existing gap here. I did a quick look on your patch and it looked good so far. The key point here is that we need dyncall as new prerequisite and make it available on all platforms (excepting Windows). The way here is to provide a wrapper module in ext_libraries in the same way as we did it with apr, apr-uitl, serf, ... We should built it and should include it directly in the office. The license seems to ok and a notice entry should be sufficient. Ok configure should be enhanced to take care of it and should handle it as usual. Are you interested to look in this as well? It would be perfect and we can support you with any questions regarding the build env and the integration of the library in the office. Anyway it looks good and your work is very much appreciated and welcome. But maybe other volunteers are interested to help here with the integration of dyncall as new prerequisite. We should definitely integrate it from my pov. Juergen
