On 3/15/13 1:09 PM, Kai Labusch wrote: > Am Freitag, 15. März 2013, 07:34:17 schrieb Ariel Constenla-Haile: >> On Fri, Mar 15, 2013 at 10:45:56AM +0100, Jürgen Schmidt wrote: >>> On 3/15/13 10:20 AM, Ariel Constenla-Haile wrote: >>>> On Wed, Mar 13, 2013 at 02:30:26PM +0100, Jürgen Schmidt wrote: >>>>> - a missing include of XInterface in the new IDL >>>>> XMarkingAccess.idl, IDL compile error on Mac, surprising that it >>>>> worked for you >>>> >>>> This is a bug, the one that removed the need for explicitly >>>> inheriting from XInterface should have taken care for not needing >>>> to include the IDL, what sounds like a non-sense (do not explicitly >>>> inherit, but include the header!). >>> >>> I agree that it's a bug >>> >>>>> The interface name "XMarkingAccess" and the method name >>>>> "invalidateMarkings" sounds somewhat strange but I have to >>>>> confess that I don't have a much better name in place. Maybe >>>>> somebody else has a good name in mind? >>>> >>>> IMHO what it does is more problematic than how it's named; see my >>>> comment on the bug. >>> >>> issue https://issues.apache.org/ooo/show_bug.cgi?id=121733 >> >> Not this one, but https://issues.apache.org/ooo/show_bug.cgi?id=121732 >> invalidation should be triggered on a TextMarkupType base, just like in >> XFlatParagraph::setChecked, otherwise a smart tag extension triggers >> unnecessary spell and grammar checking. >> >> >> Regards > > Hi, > > I agree with both, i.e., using the correct types instead of strings and > selectively invalidating markup rather than doing it for all types of markup > at once. > > I'll modify and update the patches as soon as possible. > > As a first step, it would be sufficient for our purposes, if the extension > could specify the color of a smart-tag. > > Would it reduce your concerns that the patches would give to much control to > the extension if we remove the possibilty to specify the line type? > > However, I already heared some complaints that the smart-tags are not visible > enough. In other editor applications, we change the background color of > the text in order to make the problems more visible. In the long run, it > would > be nice if one could introduce a more obvious marking mechanism in AOO.
That can of course make sense and it's worth to think about it more general. I also noticed that when you zoom a text document the lines for redlining as well as for smarttags, etc. are not zoomed in the same way and makes it less visible. But this seems to be a general issue. Juergen > > Regards, > Kai Labusch > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
