On 04.08.2013 23:19, janI wrote:
On 4 August 2013 22:53, janI <[email protected]> wrote:
Hi.
I have taken a very deep breath and added a new option to build.pl
if you run
build --all --genPO
dmake will not (as usual be called without parameters), but as "dmake
genPO". I need this to let the makefiles extract all texts from the source
files.
I have little experience with perl, so I hope someone can do a review
please.
I have committed the change in branch l1040 as R1510342.
Look forward to hear comments (or get changes).
I forgot a test message and removed the need for --all, please look at
R1510347 instead.
I looked at your changes ([r1510342], [r1510347]) and have some
questions and remarks:
- Maybe this would be an opportunity to start readable variable names: I
have no idea what $corDmake means.
- Instead of setting up the local $corDmake, maybe you could add the
genPO target (or option?) to $dmake in get_commands()
- Maybe it would be possible to avoid a new build option altogether and
use something like 'debug=t'?
In get_options() such unrecognized "options" are appended to
@dmake_args, and in get_commands() @dmake_args is
appended to $dmake.
Best regards,
Andre
r1510342:
http://svn.apache.org/viewvc/openoffice/branches/l10n40/main/solenv/bin/build.pl?r1=1505507&r2=1510342&pathrev=1510347
r1510347:
http://svn.apache.org/viewvc/openoffice/branches/l10n40/main/solenv/bin/build.pl?r1=1510342&r2=1510347&pathrev=1510347
rgds
jan I.
rgds
jan I
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
