++1
> On Oct 6, 2020, at 12:33 PM, Don Lewis <truck...@apache.org> wrote: > > On 6 Oct, Jim Jagielski wrote: >> Thanks! Since these are relatively new, I think that this can hold for 4.1.9 > > I'd at least like to get the nss update into trunk/AOO42X where it can > soak for a while. > >>> On Oct 6, 2020, at 12:19 PM, Don Lewis <truck...@apache.org> wrote: >>> >>> On 6 Oct, Jim Jagielski wrote: >>>> OK... as expected, it fails on macOS. >>>> >>>> 2 things I see: in the nss.patch file there is a line: >>>> >>>> Only in misc/build/nss-3.39/nss/coreconf: Darwin.mk.rej >>>> >>>> So I'm wondering if the patch file itself or maybe even the whole pull >>>> request is borked. >>>> >>>> Also, we need to force 'g++' on the macOS build to include '-std=c++11' >>> >>> I missed that the patch to Darwin.mk was rejected when I applied the >>> pre-update version of the patch. I regenerated nss.patch, so these >>> issues should be fixed now, or at least should be much better. >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >>> For additional commands, e-mail: dev-h...@openoffice.apache.org >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org >> For additional commands, e-mail: dev-h...@openoffice.apache.org >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org > <mailto:dev-unsubscr...@openoffice.apache.org> > For additional commands, e-mail: dev-h...@openoffice.apache.org > <mailto:dev-h...@openoffice.apache.org>
