Hello Matthias, All,
apparently, compatibility with the latest GNU Make is not yet ensured.
On Tue, Dec 06, 2022 at 01:20:17PM +0100, Matthias Seidel wrote:
> And in the end it doesn't build:
>
> ---
>
> =============
> Building module slideshow
> =============
>
> Entering /cygdrive/c/Source/openoffice/main/slideshow/prj
>
> cd .. && make -s -r -j1 && make -s -r deliverlog
> [ build CXX ] slideshow/source/engine/slideshowimpl
> slideshowimpl.cxx
> c:/Source/openoffice/main/slideshow/source/engine/slideshowimpl.cxx(25)
> : fatal error C1083: Cannot open include file:
> 'precompiled_slideshow.hxx': No such file or directory
> make: *** No rule to make target
> '/cygdrive/c/Source/openoffice/main/solver/420/wntmsci12.pro/workdir/CxxObject/slideshow/source/engine/slideshowimpl.o',
> needed by
> '/cygdrive/c/Source/openoffice/main/solver/420/wntmsci12.pro/workdir/LinkTarget/StaticLibrary/sldshw_s.lib'.
>
> Stop.
> dmake: Error code 2, while making 'all'
[...]
This seems to be a different problem than addressed with PR #175.
The slideshow module seems to fail because the slideshowimpl.cxx file
is not provided the correct include path.
There are two Makefiles, inside module slideshow, where the
slideshowimpl "object" is listed:
- StaticLibrary_sldshw_s.mk: that contains the proper build
parameters passed to:
* gb_StaticLibrary_add_api,
* gb_StaticLibrary_set_include.
- Library_slideshow.mk that does not list any of the above.
If I add to the second file the calls to gb_Library_add_api and
gb_Library_set_include, with the same parameters as the static library
counterparts, then the compilation seems to be successful.
If the above is not clear, I can open a PR proposing the above edits.
But the question is: why is the same "object" "slideshowimpl" listed
in two files? The second has a comment stating:
# List this file again, even though it's in the static lib, so that
# component_getFactory and component_getImplementationEnvironment are
exported:
This seems to be broken now, with the latest GNU Make.
I hope this makes sense.
Best regards,
--
Arrigo
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
