On Sun, May 25, 2025 at 5:07 PM Carl Marcum <carl.b.mar...@gmail.com> wrote:
> Hi Damjan, > > On 7/17/24 11:48 PM, Damjan Jovanovic wrote: > > Hi > > > > Over the last month or so, over 88 commits, I've made many improvements > to > > our unit tests, and many related changes, and have now pushed these > changes > > to trunk. > > > > <snip> > > > > In terms of future developments, maybe we should move the "complex" tests > > (and eventually "unoapi" tests too) from main/<module>/qa/complex to > test/? > > That way, we would have only 2 types of tests: the module-specific unit > > tests that run during the build, usually using Google Test, and the > > "subsequent tests" which need a full OpenOffice to test, and thus run > after > > the build from test/, and can even be run on a different instance of AOO. > > Yes this makes sense to me. > > Would they get their own test suite or fit into exist ones? > > As I was explaining in my more recent test-related email thread: ------------------------------------------------- The new "api" test type in tests/ ------------------------------------------------- In addition to the previous "bvt", "fvt" and "pvt" tests, there is now a new "api" test type I've created as well, containing these tests ported from main/qadevOOo. It's in test/testuno/source/api. I am currently trying to port the linguistic2 tests there too, but many of them fail, and I think that test suite was designed to run in a build with all the languages and dictionaries. > > <snip> > > > > Tests aren't the most exciting thing to develop. But they are important > in > > maintaining code quality, helping to discover bugs and regressions. Some > > confusing tests were also holding me back from upgrading dmake modules to > > gbuild. > This was where my interest was :) > > > > Regards > > Damjan > > > > Thank you for your work on this! > > I look forward to getting back into it as time allows. > > Best regards, > > Carl > > > Regards Damjan