Hi Stephan and all,
this is an answer to the _original_ posting!
Stephan Bergmann wrote:
1 STLport
I already wrote this before, but maybe it did not get the necessary
attention. To ensure that all spurious warnings from within any STLport
headers are suppressed, the following changes are necessary:
On unxsoli4 and unxsols4 the warnings inllargeuse ("function is too
large and will not be expanded inline") and notemsource ("Could not find
source for function") are globally disabled in each compilation unit
(regardless of whether or not it includes an STLport header), because
those warnings seem to only be generated at the end of a compilation unit.
I think these to be ok, because (correct me if I am wrong):
- inllargeuse
is only an optimization issue, it won't change semantics. It may change
performance, but I consider those cases quite rare.
- notemsource
Won't this be found by the linker again, if it is indeed a problem?
On wntmsci10 the warnings 4514 ("unreferenced inline function has been
removed")
That is a rather useless warning anyway. The inline function may be
needed elsewhere, so this message does not help.
and 4710 ("function not inlined")
I'd have voted to remove this waring from our sets anyway. Why should
non-inlined functions ever be a problem? Good programming practice is to
optimize by inlining only where a real performance need has occurred.
2 doubunder
It is a pity we violate the C++ standard with our identifiers!
But as we do not intend to change this, the warning is rather useless.
3 OSL_VERIFY
On unxsoli4 and unxsols4 PRODUCT builds, OSL_VERIFY(a == b) causes a
spurious warning "The result of a comparison is unused" (because the
argument of OSL_VERIFY is always executed, even for OSL_DEBUG_LEVEL ==
0). Instead of disabling the corresponding unxsoli4 and unxsols4
warning, I would vote to change code
My suggestion would be
#if OSL_DEBUG_LEVEL != 0
// ...
#else
#define OSL_VERIFY(x)
#endif
The issue of consolidating our error/assertion handling is a good one! ;-)
But as Stephan said, not for this CWS!
Nikolai
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
